From: "André Schwarz" <Andre.Schwarz@matrix-vision.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] init FEC @ MPC5200
Date: Thu, 11 Dec 2008 00:34:18 +0100 [thread overview]
Message-ID: <494051FA.5060008@matrix-vision.de> (raw)
In-Reply-To: <49400677.5090201@gmail.com>
Ben Warren wrote:
> Andre Schwarz wrote:
>> Ben,
>>
>> after cloning the latest u-boot git I can see that you've added this
>> inside the mvBC-P board setup :
>>
>> int board_eth_init(bd_t *bis)
>> {
>> cpu_eth_init(bis); /* Built in FEC comes first */
>> return pci_eth_init(bis);
>> }
>>
>> Are you aware that there's no PHY connected and the ETH-Pins are used
>> otherwise ?
>>
>> CONFIG_MPC5xxx_FEC is _not_ defined.
>>
>>
>> Can you tell me where "cpu_eth_init(bis)" is actually pointing to ?
>>
>>
>>
> Since CONFIG_MPC5xxx_FEC isn't defined, the default weak
> cpu_eth_init() function in net/eth.c should get called, which does
> essentially nothing. I assumed that since you #undef'd the FEC
> controller in your board header file (instead of leaving it out
> completely), that it was perhaps optional, and so kept the call to
> cpu_eth_init() as shown above.
ok - missed that.
>
> Are you seeing a problem with this?
no - just wanted to know.
Thanks for the hint,
Andr?
>> regards,
>> Andr?
>>
>> MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler -
>> Registergericht: Amtsgericht Stuttgart, HRB 271090
>> Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
>>
> regards,
> Ben
MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090
Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner
prev parent reply other threads:[~2008-12-10 23:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 10:41 [U-Boot] init FEC @ MPC5200 Andre Schwarz
2008-12-10 18:12 ` Ben Warren
2008-12-10 23:34 ` André Schwarz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494051FA.5060008@matrix-vision.de \
--to=andre.schwarz@matrix-vision.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox