From: Ilya Yanok <yanok@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] jffs2: rewrite jffs2 scanning code based on Linux one
Date: Thu, 11 Dec 2008 05:49:03 +0300 [thread overview]
Message-ID: <49407F9F.5080100@emcraft.com> (raw)
In-Reply-To: <200812101430.43180.sr@denx.de>
Hi Stefan,
Stefan Roese wrote:
> After this patch is now applied to the main u-boot repo, I get the
> following warning when compiling my new board with OneNAND & JFFS2
> support:
>
> [stefan at kubuntu u-boot (vcth-onenand-ubi-ver3)]$ make -s -j5
> jffs2_1pass.c:1411:1: warning: "min_t" redefined
> In file included
> from /home/stefan/git/u-boot/u-boot/include/linux/mtd/mtd-abi.h:11,
> from /home/stefan/git/u-boot/u-boot/include/linux/mtd/mtd.h:11,
> from jffs2_1pass.c:275:
> /home/stefan/git/u-boot/u-boot/include/linux/mtd/compat.h:34:1: warning: this is
> the location of the previous definition
>
> As it seems you added the "min_t" define to this file (see below). Why
> was this needed? I can safely remove it from my version. Do you see a
> problem with removing it on your test platform?
>
Thanks for reporting. That's obviously because we already have min_t
definition in <linux/mtd/compat.h> and OneNAND support includes this
header from somewhere while NOR support doesn't. I've changed
jffs2_1pass.c to directly include <linux/mtd/compat.h> directly instead
of defining own min_t. Please see patch in the follow up message.
Regards, Ilya.
next prev parent reply other threads:[~2008-12-11 2:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 16:49 [U-Boot] [RFC PATCH 0/6] Some speed improvements to U-Boot JFFS2 code (updated) Ilya Yanok
2008-11-13 16:49 ` [U-Boot] [PATCH 1/6] jffs2: fix searching for latest version in jffs2_1pass_list_inodes() Ilya Yanok
2008-12-09 22:38 ` Wolfgang Denk
2008-11-13 16:49 ` [U-Boot] [PATCH 2/6] jffs2: add sector_size field to part_info structure Ilya Yanok
2008-11-13 18:01 ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-13 18:16 ` Ben Warren
2008-12-09 22:39 ` Wolfgang Denk
2008-11-13 16:49 ` [U-Boot] [PATCH 3/6] jffs2: rewrite jffs2 scanning code based on Linux one Ilya Yanok
2008-11-13 18:06 ` Jean-Christophe PLAGNIOL-VILLARD
2008-11-20 14:31 ` Ilya Yanok
2008-12-09 22:39 ` Wolfgang Denk
2008-12-10 13:30 ` Stefan Roese
2008-12-11 2:49 ` Ilya Yanok [this message]
2008-12-11 2:51 ` [U-Boot] [PATCH] jffs2: include <linux/mtd/compat.h> instead of defining own min_t Ilya Yanok
2008-12-11 6:24 ` Stefan Roese
2008-12-16 16:14 ` Wolfgang Denk
2008-11-13 16:49 ` [U-Boot] [PATCH 4/6] jffs2: add buffer to cache flash accesses Ilya Yanok
2008-12-09 22:41 ` Wolfgang Denk
2008-11-13 16:49 ` [U-Boot] [PATCH 5/6] jffs2: summary support Ilya Yanok
2008-12-09 22:41 ` Wolfgang Denk
2008-11-13 16:49 ` [U-Boot] [PATCH 6/6] jffs2: cache data_crc results Ilya Yanok
2008-12-09 22:41 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49407F9F.5080100@emcraft.com \
--to=yanok@emcraft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox