From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilya Yanok Date: Thu, 11 Dec 2008 05:49:03 +0300 Subject: [U-Boot] [PATCH 3/6] jffs2: rewrite jffs2 scanning code based on Linux one In-Reply-To: <200812101430.43180.sr@denx.de> References: <1226594976-6087-1-git-send-email-yanok@emcraft.com> <1226594976-6087-4-git-send-email-yanok@emcraft.com> <200812101430.43180.sr@denx.de> Message-ID: <49407F9F.5080100@emcraft.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefan, Stefan Roese wrote: > After this patch is now applied to the main u-boot repo, I get the > following warning when compiling my new board with OneNAND & JFFS2 > support: > > [stefan at kubuntu u-boot (vcth-onenand-ubi-ver3)]$ make -s -j5 > jffs2_1pass.c:1411:1: warning: "min_t" redefined > In file included > from /home/stefan/git/u-boot/u-boot/include/linux/mtd/mtd-abi.h:11, > from /home/stefan/git/u-boot/u-boot/include/linux/mtd/mtd.h:11, > from jffs2_1pass.c:275: > /home/stefan/git/u-boot/u-boot/include/linux/mtd/compat.h:34:1: warning: this is > the location of the previous definition > > As it seems you added the "min_t" define to this file (see below). Why > was this needed? I can safely remove it from my version. Do you see a > problem with removing it on your test platform? > Thanks for reporting. That's obviously because we already have min_t definition in and OneNAND support includes this header from somewhere while NOR support doesn't. I've changed jffs2_1pass.c to directly include directly instead of defining own min_t. Please see patch in the follow up message. Regards, Ilya.