From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] SATA: do not auto-initialize during boot
Date: Thu, 11 Dec 2008 15:01:33 -0600 [thread overview]
Message-ID: <49417FAD.4050702@freescale.com> (raw)
In-Reply-To: <200812111556.23044.vapier@gentoo.org>
Mike Frysinger wrote:
> On Thursday 11 December 2008 15:51:32 Kumar Gala wrote:
>> 'sata init' isn't safe. It seems like you should only be able to call
>> it once. However I think we can keep issuing it and cause bad things
>> to happen.
>
> i dont think so. the SATA driver should be doing the right thing: init_sata()
> should get the hardware into a usable state regardless of how it was before.
So then what's the downside to having any sata access automatically call
init_sata()?
>> Also, in the code you removed we do a runtime check on 8536 to see if
>> SATA is even available. That check is still valid.
>
> why ? if the hardware doesnt support it, then the user shouldnt be attempting
> to use it. if they do, that's their fault for doing something stupid.
There's no need to be unnecessarily user-hostile.
-Scott
next prev parent reply other threads:[~2008-12-11 21:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 8:04 [U-Boot] SATA/IDE/etc... init Mike Frysinger
2008-12-11 10:12 ` Wolfgang Denk
2008-12-11 10:32 ` [U-Boot] [PATCH] SATA: do not auto-initialize during boot Mike Frysinger
2008-12-11 16:17 ` Kumar Gala
2008-12-11 20:03 ` Mike Frysinger
2008-12-11 20:51 ` Kumar Gala
2008-12-11 20:56 ` Mike Frysinger
2008-12-11 21:01 ` Scott Wood [this message]
2008-12-11 21:07 ` Mike Frysinger
2008-12-11 21:16 ` Scott Wood
2008-12-11 21:24 ` Mike Frysinger
2008-12-11 21:36 ` Scott Wood
2008-12-11 22:06 ` Mike Frysinger
2008-12-11 23:57 ` Wolfgang Denk
2008-12-23 5:53 ` Mike Frysinger
2008-12-11 23:55 ` Wolfgang Denk
2008-12-11 23:53 ` Wolfgang Denk
2008-12-11 23:57 ` Mike Frysinger
2008-12-12 0:15 ` Scott Wood
2008-12-23 5:51 ` Mike Frysinger
2008-12-11 23:50 ` Wolfgang Denk
2008-12-11 23:49 ` Wolfgang Denk
2008-12-11 16:18 ` Kumar Gala
2008-12-11 20:02 ` Mike Frysinger
2008-12-11 23:18 ` Wolfgang Denk
2008-12-11 23:26 ` Kumar Gala
2008-12-12 0:01 ` Wolfgang Denk
2008-12-12 0:13 ` Kumar Gala
2008-12-11 12:47 ` [U-Boot] SATA/IDE/etc... init Mike Frysinger
2008-12-11 19:23 ` Scott Wood
2008-12-11 23:22 ` Wolfgang Denk
2008-12-11 23:48 ` Mike Frysinger
2008-12-11 23:51 ` [U-Boot] [PATCH v2] SATA: do not auto-initialize during boot Mike Frysinger
2008-12-12 0:16 ` Kumar Gala
2008-12-23 5:10 ` [U-Boot] [PATCH v3] " Mike Frysinger
2009-01-24 3:12 ` Mike Frysinger
2009-01-27 20:58 ` Wolfgang Denk
2009-01-27 21:12 ` [U-Boot] [PATCH v4] " Mike Frysinger
2009-01-27 22:43 ` Wolfgang Denk
2008-12-12 5:53 ` [U-Boot] SATA/IDE/etc... init Stefan Roese
2008-12-22 7:25 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49417FAD.4050702@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox