From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Thu, 11 Dec 2008 15:01:33 -0600 Subject: [U-Boot] [PATCH] SATA: do not auto-initialize during boot In-Reply-To: <200812111556.23044.vapier@gentoo.org> References: <20081211101257.29464834B020@gemini.denx.de> <200812111503.54148.vapier@gentoo.org> <3B24DCFA-1309-4B92-A4AE-D9943D33269B@kernel.crashing.org> <200812111556.23044.vapier@gentoo.org> Message-ID: <49417FAD.4050702@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Mike Frysinger wrote: > On Thursday 11 December 2008 15:51:32 Kumar Gala wrote: >> 'sata init' isn't safe. It seems like you should only be able to call >> it once. However I think we can keep issuing it and cause bad things >> to happen. > > i dont think so. the SATA driver should be doing the right thing: init_sata() > should get the hardware into a usable state regardless of how it was before. So then what's the downside to having any sata access automatically call init_sata()? >> Also, in the code you removed we do a runtime check on 8536 to see if >> SATA is even available. That check is still valid. > > why ? if the hardware doesnt support it, then the user shouldnt be attempting > to use it. if they do, that's their fault for doing something stupid. There's no need to be unnecessarily user-hostile. -Scott