[U-Boot] [PATCH] cmd_sf: rename "speed" to "hz"

Jerry Van Baren
2008-12-13T18:02:26Z

Mike Frysinger wrote:
> On Thursday 11 December 2008 18:59:46 Wolfgang Denk wrote:
>> In message Mike Frysinger you wrote:
>>> The term "hz" is used everywhere else when talking about the frequency of
>>> the SPI bus, so have the sf command use it as well to stay consistent.
>>> It even presents itself as "hz" when showing user help.
>>>
>>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>>> ---
>>> common/cmd_sf.c | 10 +++++-----
>>> 1 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/common/cmd_sf.c b/common/cmd_sf.c
>>> index 8c0a751..902e51d 100644
>>> --- a/common/cmd_sf.c
>>> +++ b/common/cmd_sf.c
>>> @@ -8,8 +8,8 @@
>>>
>>> #include <asm/io.h>
>>>
>>> -#ifndef CONFIG_SF_DEFAULT_SPEED
>>> -# define CONFIG_SF_DEFAULT_SPEED 1000000
>>> +#ifndef CONFIG_SF_DEFAULT_HZ
>>> +# define CONFIG_SF_DEFAULT_HZ 1000000
>> I consider "FREQ" (and even "SPEED) a much better name than "HZ".
>>
>> "HZ" is the unit of what you are measuring, not a name for what you
>> are measuring.
>
> then they should all be converted. not 90% using hz and 10% using something
> else. "speed" is bad as it doesnt convey the unit while "hz" is pretty clear.
> -mike

Maybe I'm being pedantic or have drunk too much coffee, but "clk" (clock
rate, _expressed_ in Hz) is better than "speed" IMHO. "bps" (bits per
second) is another alternative, although it has its own problems if the
data rate is different when sending "0" bits vs. "1" bits (e.g. 1-wire).

Best regards,
gvb