[U-Boot] [PATCH] cmd_sf: rename "speed" to "hz"

Wolfgang Denk
2008-12-12T07:22:16Z

Dear Mike Frysinger,

In message <200812112130.02918.vapier@gentoo.org> you wrote:
>
> > > -#ifndef CONFIG_SF_DEFAULT_SPEED
> > > -# define CONFIG_SF_DEFAULT_SPEED 1000000
> > > +#ifndef CONFIG_SF_DEFAULT_HZ
> > > +# define CONFIG_SF_DEFAULT_HZ 1000000
> >
> > I consider "FREQ" (and even "SPEED) a much better name than "HZ".
> >
> > "HZ" is the unit of what you are measuring, not a name for what you
> > are measuring.
>
> then they should all be converted. not 90% using hz and 10% using something

Agreed.

> else. "speed" is bad as it doesnt convey the unit while "hz" is pretty clear.

You are right, but that could be mentioned in the documentation
then...

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
People are very flexible and learn to adjust to strange surroundings
-- they can become accustomed to read Lisp and Fortran programs, for
example. - Leon Sterling and Ehud Shapiro, Art of Prolog, MIT Press