[U-Boot] [PATCH] cmd_sf: rename "speed" to "hz"

Wolfgang Denk
2008-12-11T23:59:46Z

Dear Mike Frysinger,

In message <1229034488-26048-1-git-send-email-vapier@gentoo.org> you wrote:
> The term "hz" is used everywhere else when talking about the frequency of
> the SPI bus, so have the sf command use it as well to stay consistent. It
> even presents itself as "hz" when showing user help.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> common/cmd_sf.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/common/cmd_sf.c b/common/cmd_sf.c
> index 8c0a751..902e51d 100644
> --- a/common/cmd_sf.c
> +++ b/common/cmd_sf.c
> @@ -8,8 +8,8 @@
>
> #include <asm/io.h>
>
> -#ifndef CONFIG_SF_DEFAULT_SPEED
> -# define CONFIG_SF_DEFAULT_SPEED 1000000
> +#ifndef CONFIG_SF_DEFAULT_HZ
> +# define CONFIG_SF_DEFAULT_HZ 1000000

I consider "FREQ" (and even "SPEED) a much better name than "HZ".

"HZ" is the unit of what you are measuring, not a name for what you
are measuring.

NAK.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe does not have laws - it has habits, and habits can be
broken.