From: David Hawkins <dwh@ovro.caltech.edu>
To: u-boot@lists.denx.de
Subject: [U-Boot] fat.c:707: warning: array subscript is above array bounds
Date: Sat, 13 Dec 2008 14:51:43 -0800 [thread overview]
Message-ID: <49443C7F.3020003@ovro.caltech.edu> (raw)
In-Reply-To: <20081213224823.57135832E8A1@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <20081213222225.GN15295@game.jcrosoft.org> you wrote:
>>> 705 /* Terminate fs_type string. Writing past the end of vistart
>>> 706 is ok - it's just the buffer. */
>>> 707 vistart->fs_type[8] = '\0';
>> why not do something like this
>>
>> *(vistart + sizeof(volume_info)) = '\0';
>
> Because that would be terribly wrong - sizeof(volume_info) is > 23
> (probably 24), and vistart is a pointer volume_info, so you would
> probably write some 500+ bytes beyond the end of the buffer.
How about something in the same vein then
char *c = vistart->fstype;
c[8] = '\0';
Cheers,
Dave
next prev parent reply other threads:[~2008-12-13 22:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 22:13 [U-Boot] fat.c:707: warning: array subscript is above array bounds Wolfgang Denk
2008-12-13 22:22 ` Jean-Christophe PLAGNIOL-VILLARD
2008-12-13 22:48 ` Wolfgang Denk
2008-12-13 22:51 ` David Hawkins [this message]
2009-01-27 20:51 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49443C7F.3020003@ovro.caltech.edu \
--to=dwh@ovro.caltech.edu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox