public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: michael <trimarchi@gandalf.sssup.it>
To: u-boot@lists.denx.de
Subject: [U-Boot] EHCI last patch
Date: Wed, 17 Dec 2008 14:08:08 +0100	[thread overview]
Message-ID: <4948F9B8.5000701@gandalf.sssup.it> (raw)
In-Reply-To: <200812121105.19708.sr@denx.de>

Hi all,

Stefan Roese wrote:
> Hi Michael,
>
> On Friday 12 December 2008, michael wrote:
>   
>> In the last ehci patch I add myself in the author of the code. I'm not
>> sure if it possible. I change
>> the codes and test it but I don't know if the change are sufficient.
>>     
>
> You added yourself not as author but you added your Copyright. With all the 
> work you have done to this code lately I'm pretty sure that this is ok.
>
> Thanks for all your work on this. And please don't forget to add the EHCI-PCI 
> support as well.
>   
I have rewrite and clean the support for ehci-pci but I don't have any 
hardware to test on it. My
code is like this:

int ehci_hcd_init(void)
{
        pci_dev_t pdev;
        uint32_t addr;

        pdev = pci_find_devices(ehci_pci_ids, CONFIG_PCI_EHCI_DEVICE);
        if (dev == -1) {
                printf("EHCI host controller not found\n");
                return -1;
        }

        pci_read_config_dword(dev, PCI_BASE_ADDRESS_0, &addr);
        hccr = (struct ehci_hccr *)addr;
        hcor = (struct ehci_hcor *)((uint32_t) hccr +
                        HC_LENGTH(ehci_readl(&hccr->cr_capbase)));

        return 0;
}

and the CONFIG_PCI_EHCI_DEVICE. I notice that there is a table in 
usb_ohci too. Is there any
reason?

#ifdef CONFIG_PCI_EHCI_DEVICE
static struct pci_device_id ehci_pci_ids[] = {
        /* Please add supported PCI EHCI controller ids here */
        {0, 0}
};
#endif

It is very simple. The problem is thath currently I don't have any other 
hardware to test the code.
I have done some cleanup and I have the ixp4xx usb host support ready 
too. Are there people with ehci
hardware running u-boot?

Michael

  reply	other threads:[~2008-12-17 13:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-12  9:57 [U-Boot] EHCI last patch michael
2008-12-12 10:05 ` Stefan Roese
2008-12-17 13:08   ` michael [this message]
2008-12-17 15:05     ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4948F9B8.5000701@gandalf.sssup.it \
    --to=trimarchi@gandalf.sssup.it \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox