public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: michael <trimarchi@gandalf.sssup.it>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb_storage: do not reset SanDisk Corporation U3 Cruzer Micro USB thumb drive
Date: Fri, 02 Jan 2009 13:47:48 +0100	[thread overview]
Message-ID: <495E0CF4.4030506@gandalf.sssup.it> (raw)
In-Reply-To: <200901020650.34962.vapier@gentoo.org>

Hi,

Mike Frysinger wrote:
> On Friday 02 January 2009 06:26:39 Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 19:48 Thu 01 Jan     , Mike Frysinger wrote:
>>> From: Bryan Wu <Bryan.Wu@analog.com>
>>>
>>> The SanDisk Corporation U3 Cruzer Micro 1/4GB Flash Drive
>>> 000016244373FFB4 does not like to be reset, so check for it.
>>>
>>> Signed-off-by: Bryan Wu <bryan.wu@analog.com>
>>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>>> ---
>>>  common/usb_storage.c |    7 +++++++
>>>  1 files changed, 7 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/common/usb_storage.c b/common/usb_storage.c
>>> index 94f659f..94124f8 100644
>>> --- a/common/usb_storage.c
>>> +++ b/common/usb_storage.c
>>> @@ -1166,6 +1166,13 @@ int usb_stor_get_info(struct usb_device
>>> *dev,struct us_data *ss,block_dev_desc_t /* SanDisk Corporation Cruzer
>>> Micro 20044318410546613953 */ (dev->descriptor.idVendor == 0x0781 &&
>>>  	     dev->descriptor.idProduct == 0x5151)
>>> +	    ||
>>> +	    /*
>>> +	     * SanDisk Corporation U3 Cruzer Micro 1/4GB
>>> +	     * Flash Drive 000016244373FFB4
>>> +	     */
>>> +	    (dev->descriptor.idVendor == 0x0781 &&
>>> +	     dev->descriptor.idProduct == 0x5406)
>>>  	    )
>> instead of add more and more if else case
>> why not add a fixup function?
>
> feel free to ask/take it up with the usb maintainer.  we work with what's 
> there rather than being creative.
> -mike
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>   
I sent a clean-up patch for the usb_storage few weeks ago ([U-Boot] 
[PATCH] USB storage cleanup patch), then
 I can carry on the fixup function too.

Michael

  reply	other threads:[~2009-01-02 12:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-30  7:59 [U-Boot] [PATCH] usb_storage: do not reset SanDisk Corporation U3 Cruzer Micro USB thumb drive Mike Frysinger
2008-12-30 22:52 ` Wolfgang Denk
2008-12-31  2:48   ` Bryan Wu
2008-12-31  7:42   ` Mike Frysinger
2008-12-31 19:38     ` Wolfgang Denk
2009-01-01  7:52       ` Mike Frysinger
2009-01-01  7:52       ` [U-Boot] [PATCH v2] " Mike Frysinger
2009-01-01  9:01         ` Wolfgang Denk
2009-01-01  9:10           ` Mike Frysinger
2009-01-01 10:32             ` Remy Bohmer
2009-01-02  0:48               ` [U-Boot] [PATCH] " Mike Frysinger
2009-01-02 11:26                 ` Jean-Christophe PLAGNIOL-VILLARD
2009-01-02 11:50                   ` Mike Frysinger
2009-01-02 12:47                     ` michael [this message]
2009-01-02 13:12                       ` Remy Bohmer
2009-01-04 20:33                 ` Remy Bohmer
2009-01-01 13:53             ` [U-Boot] [PATCH v2] " Wolfgang Denk
2009-01-01 23:32               ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=495E0CF4.4030506@gandalf.sssup.it \
    --to=trimarchi@gandalf.sssup.it \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox