public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC/PATCH 1/4] Enable multi chip support in the NAND layer
Date: Fri, 16 Jan 2009 18:15:50 +0100	[thread overview]
Message-ID: <4970C0C6.2090208@grandegger.com> (raw)
In-Reply-To: <20090116082201.9BC0E832E425@gemini.denx.de>

Wolfgang Denk wrote:
> Dear Wolfgang,
> 
> In message <49703E5B.1080604@grandegger.com> you wrote:
>> Yep, in the meantime I realized that it's already pre-set in
>> include/linux/mtd/nand.h:
>>
>>   /* The maximum number of NAND chips in an array */
>>   #ifndef NAND_MAX_CHIPS
>>   #define NAND_MAX_CHIPS          8
>>   #endif
>>
>> but most (if not all) boards set it to 1.
> 
> So we should change the default setting to 1, and change it only where
> needed.

Actually, none of the boards use multi-chip support (NAND_MAX_CHIPS >
1). The bamboo and the DU440 define

  #define NAND_MAX_CHIPS          CONFIG_SYS_MAX_NAND_DEVICE

but that's bogus and did not work yet anyhow.

>> But at that occasion, I think the name should be changed to
>> CONFIG_SYS_NAND_MAX_CHIPS, right?
> 
> Right.

OK, I will prepare a patch removing all NAND_MAX_CHIPS from the board
config files, rename if to CONFIG_SYS_NAND_MAX_CHIPS and define a
default of 1 for the legacy and the new MTD NAND layer.

Wolfgang.

  reply	other threads:[~2009-01-16 17:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-07 18:53 [U-Boot] [RFC/PATCH 1/4] Enable multi chip support in the NAND layer Wolfgang Grandegger
2009-01-15 22:17 ` Scott Wood
2009-01-16  7:59   ` Wolfgang Grandegger
2009-01-16  8:22     ` Wolfgang Denk
2009-01-16 17:15       ` Wolfgang Grandegger [this message]
2009-01-19 16:12         ` Stefan Roese
2009-01-19 17:08           ` Scott Wood
2009-01-19 17:21             ` Stefan Roese
2009-01-19 19:50               ` Wolfgang Grandegger
2009-01-20  7:40                 ` Stefan Roese
2009-01-20  8:36                   ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4970C0C6.2090208@grandegger.com \
    --to=wg@grandegger.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox