public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fdt_resize(): fix actualsize calculations with unaligned blobs
Date: Sat, 17 Jan 2009 13:19:31 -0500	[thread overview]
Message-ID: <49722133.5000406@gmail.com> (raw)
In-Reply-To: <1231937544-16452-1-git-send-email-jacmet@sunsite.dk>

Peter Korsgaard wrote:
> The code in fdt_resize() to extend the fdt size to end on a page boundary
> is wrong for fdt's not located at an address aligned on a page boundary.
> What's even worse, the code would make actualsize shrink rather than grow
> if (blob & 0xfff) was bigger than the amount of padding added by ALIGN(),
> causing fdt_add_mem_rsv to fail.
> 
> Fix it by aligning end address (blob + size) to a page boundary instead.
> For aligned fdt's this is equivalent to what we had before.
> 
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>

Applied to u-boot-fdt.  I will call for Wolfgang to pull shortly.

Thanks,
gvb

      reply	other threads:[~2009-01-17 18:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-14 12:52 [U-Boot] [PATCH] fdt_resize(): fix actualsize calculations with unaligned blobs Peter Korsgaard
2009-01-17 18:19 ` Jerry Van Baren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49722133.5000406@gmail.com \
    --to=gvb.uboot@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox