[U-Boot] Coldfire: Compiler warnings when building M5271EVB

[U-Boot] Coldfire: Compiler warnings when building M5271EVB

[Richard Retanubun]

Tsi-Chung:
Sorry for the delay. I've posted the M5271 patches to the mailing list just now.

Also, I have a question about the compiler warning I see when building the M5271EVB:

cpu_init.c:57:2: warning: #warning "Chip Select 0 are not initialized/used"
cpu_init.c: In function 'init_fbcs':
cpu_init.c:49: warning: unused variable 'fbcs'

The line numbers are AFTER my patches, so they may not match yours precisely.

Is the correct answer to add CONFIG_M5271 to the this #ifndef ?

- #ifndef CONFIG_M5272
+ #if !(defined CONFIG_M5272) && !(defined CONFIG_M5271)
/* Only 5272 Flexbus chipselect is different from the rest */
void init_fbcs(void)
{

I think that will remove the warnings for M5271, but I may be missing the 
context here :)

what is the flexBus by the way?

Thanks for the time

- Richard Retanubun

[U-Boot] Coldfire: Compiler warnings when building M5271EVB

[Liew Tsi Chung-R5AAHP]

Richard,

This error caused by no defines for CONFIG_SYS_CS0_BASE,
CONFIG_SYS_CS0_MASK and CONFIG_SYS_CS0_CTRL in configuration file. Need
to provide settings for each. The CS0 usually refer to the boot flash.

Flexbus or chipselect is the same definition.

Regards,
TsiChung 

-----Original Message-----
From: Richard Retanubun [mailto:RichardRetanubun at ruggedcom.com] 
Sent: Friday, January 23, 2009 4:28 PM
To: u-boot Mailing List
Cc: Liew Tsi Chung-R5AAHP
Subject: Coldfire: Compiler warnings when building M5271EVB

Tsi-Chung:
Sorry for the delay. I've posted the M5271 patches to the mailing list
just now.

Also, I have a question about the compiler warning I see when building
the M5271EVB:

cpu_init.c:57:2: warning: #warning "Chip Select 0 are not
initialized/used"
cpu_init.c: In function 'init_fbcs':
cpu_init.c:49: warning: unused variable 'fbcs'

The line numbers are AFTER my patches, so they may not match yours
precisely.

Is the correct answer to add CONFIG_M5271 to the this #ifndef ?

- #ifndef CONFIG_M5272
+ #if !(defined CONFIG_M5272) && !(defined CONFIG_M5271)
/* Only 5272 Flexbus chipselect is different from the rest */ void
init_fbcs(void) {

I think that will remove the warnings for M5271, but I may be missing
the context here :)

what is the flexBus by the way?

Thanks for the time

- Richard Retanubun

[U-Boot] Coldfire: Compiler warnings when building M5271EVB

[Richard Retanubun]

Hi Tsi Chung,

Liew Tsi Chung-R5AAHP wrote:
> Richard,
> 
> This error caused by no defines for CONFIG_SYS_CS0_BASE,
> CONFIG_SYS_CS0_MASK and CONFIG_SYS_CS0_CTRL in configuration file. Need
> to provide settings for each. The CS0 usually refer to the boot flash.
> 
> Flexbus or chipselect is the same definition.

I realized this, however, the M5271EVB.h (at least the version I have) does not
defined CONFIG_SYS_CS0_BASE, CONFIG_SYS_CS0_MASK, CONFIG_SYS_CS0_CTRL
And it boots fine without it :)

To be honest, I'm not even sure what mbar_writeBytes(??)
reg CS0_BASE, CS0_MASK and CS0_CTRL maps to?

So my question is, if the M5271EVB (and others M5270, M5271 platforms) can boot without it,
why are they required to define it?

Thanks for your time and feedback on the other patches.

- Richard Retanubun

> 
> Regards,
> TsiChung 
> 
> -----Original Message-----
> From: Richard Retanubun [mailto:RichardRetanubun at ruggedcom.com] 
> Sent: Friday, January 23, 2009 4:28 PM
> To: u-boot Mailing List
> Cc: Liew Tsi Chung-R5AAHP
> Subject: Coldfire: Compiler warnings when building M5271EVB
> 
> Tsi-Chung:
> Sorry for the delay. I've posted the M5271 patches to the mailing list
> just now.
> 
> Also, I have a question about the compiler warning I see when building
> the M5271EVB:
> 
> cpu_init.c:57:2: warning: #warning "Chip Select 0 are not
> initialized/used"
> cpu_init.c: In function 'init_fbcs':
> cpu_init.c:49: warning: unused variable 'fbcs'
> 
> The line numbers are AFTER my patches, so they may not match yours
> precisely.
> 
> Is the correct answer to add CONFIG_M5271 to the this #ifndef ?
> 
> - #ifndef CONFIG_M5272
> + #if !(defined CONFIG_M5272) && !(defined CONFIG_M5271)
> /* Only 5272 Flexbus chipselect is different from the rest */ void
> init_fbcs(void) {
> 
> I think that will remove the warnings for M5271, but I may be missing
> the context here :)
> 
> what is the flexBus by the way?
> 
> Thanks for the time
> 
> - Richard Retanubun
>