public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Derek Ou <derek@siconix.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] nand sector size is zero in jffs2 cmds
Date: Mon, 26 Jan 2009 11:18:49 -0700	[thread overview]
Message-ID: <497DFE89.7020301@siconix.com> (raw)
In-Reply-To: <20090124005317.5412A832E425@gemini.denx.de>

Hi, Wolfgang,

The following patch was tested some time ago.  I am in the middle of 
another task and can not
verify this patch with the latest code. Should I just reformat my patch 
and submit it or should I
wait till I can test it with the latest code?

Also, I found that jffs2 scanning routine does not skip the bad blocks 
in NAND in my
previous test.  Does anybody else see this behavior?

BTW, what is the best way to submit patches?  I tried git-format-patch 
approach described in
http://www.denx.de/wiki/U-Boot/GnatsEmail
But git-send-email is not easy to use.  I tried just copy and paste but 
thunderbird convert all the
tabs into spaces.  I ended up using copy and paste and webmail interface 
to send out another
patch.  But I will love to hear a better way of doing it.

Thanks,
Derek
Wolfgang Denk wrote:
> Dear Derek Ou,
>
> In message <49515BD6.9030606@siconix.com> you wrote:
>   
>> The "### ERROR ### Please RESET the board ###" error and the zero NAND 
>> sector size problem can be fixed by the following patch.  However, the 
>> jffs2 scanning routine does not skip the bad blocks in NAND though.
>>
>> Derek
>> ************* patch **************
>> index 7866c80..f6966f3 100644
>> --- a/common/cmd_jffs2.c
>> +++ b/common/cmd_jffs2.c
>> @@ -1853,6 +1853,8 @@ int mtdparts_init(void)
>>                 if (part->size == SIZE_REMAINING)
>>                         part->size = id->size - part->offset;
>>  
>> +               part->sector_size = nand_info[id->num].erasesize;
>> +
>>                 DEBUGF("part  : name = %s, size = 0x%08lx, offset = 
>> 0x%08lx\n",
>>                                 part->name, part->size, part->offset);
>>     
> Can you please submit a proper patch (after fixing your mailer
> configuration which wraps long lines, thus corrupting the patch)?
>
> See http://www.denx.de/wiki/U-Boot/Patches for instructions.
>
> Best regards,
> Wolfgang Den

  reply	other threads:[~2009-01-26 18:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-23  1:02 [U-Boot] nand sector size is zero in jffs2 cmds Derek Ou
2008-12-23 21:44 ` Derek Ou
2009-01-24  0:53   ` Wolfgang Denk
2009-01-26 18:18     ` Derek Ou [this message]
2009-01-27 21:01       ` Wolfgang Denk
2009-01-06 19:03 ` [U-Boot] env_nand malloc not released Derek Ou
2009-01-07 22:15   ` Scott Wood
2009-01-24  0:53   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=497DFE89.7020301@siconix.com \
    --to=derek@siconix.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox