From: Mark Jackson <mpfj-list@mimc.co.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Add 16bpp BMP support
Date: Tue, 27 Jan 2009 12:21:18 +0000 [thread overview]
Message-ID: <497EFC3E.8050403@mimc.co.uk> (raw)
In-Reply-To: <20090127121534.9561B832E416@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Mark Jackson,
<snip>
> No, this still makes no sense to me. Listing all the accrhitectures
> where this is implemented or not is error prone, and this file should
> definitely be as independent from specific hardware properties as
> possible.
>
> Can we not agree on some generic name (like CONFIG_BMP_16BPP) and
> #define this only on those boards that can do it / need it? Then we
> can omit all the "elif" ... lists.
Ah yes ... a much cleaner solution.
In fact, I guess there's no reason to #define any of this, since we're
switching on the bpp anyway !!
What if I just remove all the extranous #defines all together ? And just
leave the inner "#if defined(CONFIG_ATMEL_LCD_BGR555)" ?
Regards
Mark
next prev parent reply other threads:[~2009-01-27 12:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 11:32 [U-Boot] [PATCH v2] Add 16bpp BMP support Mark Jackson
2009-01-27 12:15 ` Wolfgang Denk
2009-01-27 12:21 ` Mark Jackson [this message]
2009-01-27 12:56 ` Wolfgang Denk
2009-01-27 12:58 ` Mark Jackson
2009-01-27 12:58 ` [U-Boot] Reset command on u-boot command line not working Ajeesh Kumar
2009-01-27 13:16 ` Roman Mashak
2009-01-27 13:35 ` Ajeesh Kumar
2009-01-27 13:51 ` Wolfgang Denk
2009-01-27 14:13 ` Ajeesh Kumar
2009-01-27 14:33 ` Kumar Gala
2009-01-27 15:05 ` Jayakrishnan M
2009-01-29 2:48 ` Ajeesh Kumar
2009-01-27 14:53 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497EFC3E.8050403@mimc.co.uk \
--to=mpfj-list@mimc.co.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox