From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Jackson <mpfj-list@mimc.co.uk>
Date: Tue, 27 Jan 2009 12:21:18 +0000
Subject: [U-Boot] [PATCH v2] Add 16bpp BMP support
In-Reply-To: <20090127121534.9561B832E416@gemini.denx.de>
References: <497EF0C4.3060907@mimc.co.uk>
	<20090127121534.9561B832E416@gemini.denx.de>
Message-ID: <497EFC3E.8050403@mimc.co.uk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
> Dear Mark Jackson,

<snip>

> No, this still makes no sense to me. Listing all the accrhitectures
> where this is implemented or not is error prone, and this file should
> definitely be as independent from specific hardware properties as
> possible.
> 
> Can we not agree on some generic name (like CONFIG_BMP_16BPP) and
> #define this only on those boards that can do it / need it? Then we
> can omit all the "elif" ... lists.

Ah yes ... a much cleaner solution.

In fact, I guess there's no reason to #define any of this, since we're 
switching on the bpp anyway !!

What if I just remove all the extranous #defines all together ?  And just 
leave the inner "#if defined(CONFIG_ATMEL_LCD_BGR555)" ?

Regards
Mark