public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 02/31] environment, netconsole: reducing packages when printing environment variables
Date: Wed, 28 Jan 2009 10:38:39 +0100	[thread overview]
Message-ID: <4980279F.2020302@denx.de> (raw)

Actual, do_printenv () uses putc () to print the Environment-
variables. If using netconsole, this will result in a lot of
packages with single characters in it. With the new config
option CONFIG_ENV_BUFFER_PRINT do_printenv () uses now puts ()
to print a complete Environmentvariable, so the number of
packages when using netconsole are reduced.

Signed-off-by: Heiko Schocher <hs@denx.de>
---
 common/cmd_nvedit.c      |    8 ++++++++
 include/configs/mgcoge.h |    1 +
 include/configs/mgsuvd.h |    1 +
 3 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
index 85025da..8f6310a 100644
--- a/common/cmd_nvedit.c
+++ b/common/cmd_nvedit.c
@@ -89,8 +89,12 @@ int do_printenv (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 		for (i=0; env_get_char(i) != '\0'; i=nxt+1) {
 			for (nxt=i; env_get_char(nxt) != '\0'; ++nxt)
 				;
+#if defined(CONFIG_ENV_BUFFER_PRINT)
+			puts ((char *)( env_get_addr(nxt) + 1));
+#else
 			for (k=i; k<nxt; ++k)
 				putc(env_get_char(k));
+#endif
 			putc  ('\n');

 			if (ctrlc()) {
@@ -118,11 +122,15 @@ int do_printenv (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 			if (k < 0) {
 				continue;
 			}
+#if defined(CONFIG_ENV_BUFFER_PRINT)
+			printf ("%s=%s\n", name, (char *)( env_get_addr(k)));
+#else
 			puts (name);
 			putc ('=');
 			while (k < nxt)
 				putc(env_get_char(k++));
 			putc ('\n');
+#endif
 			break;
 		}
 		if (k < 0) {
diff --git a/include/configs/mgcoge.h b/include/configs/mgcoge.h
index 233bee0..9416a03 100644
--- a/include/configs/mgcoge.h
+++ b/include/configs/mgcoge.h
@@ -139,6 +139,7 @@
 #define CONFIG_ENV_OFFSET_REDUND	(CONFIG_ENV_OFFSET + CONFIG_ENV_SECT_SIZE)
 #define CONFIG_ENV_SIZE_REDUND		(CONFIG_ENV_SIZE)
 #endif /* CONFIG_ENV_IS_IN_FLASH */
+#define CONFIG_ENV_BUFFER_PRINT		1

 /* enable I2C and select the hardware/software driver */
 #undef	CONFIG_HARD_I2C			/* I2C with hardware support	*/
diff --git a/include/configs/mgsuvd.h b/include/configs/mgsuvd.h
index 8f82751..698f0e7 100644
--- a/include/configs/mgsuvd.h
+++ b/include/configs/mgsuvd.h
@@ -143,6 +143,7 @@
 /* Address and size of Redundant Environment Sector	*/
 #define CONFIG_ENV_OFFSET_REDUND	(CONFIG_ENV_OFFSET+CONFIG_ENV_SECT_SIZE)
 #define CONFIG_ENV_SIZE_REDUND	(CONFIG_ENV_SIZE)
+#define CONFIG_ENV_BUFFER_PRINT		1

 /*-----------------------------------------------------------------------
  * Cache Configuration
-- 
1.6.0.6

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

             reply	other threads:[~2009-01-28  9:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28  9:38 Heiko Schocher [this message]
2009-01-28 10:05 ` [U-Boot] [PATCH 02/31] environment, netconsole: reducing packages when printing environment variables Stefan Roese
2009-01-28 10:27   ` Heiko Schocher
2009-01-28 11:31     ` Wolfgang Denk
2009-01-28 11:56       ` Stefan Roese
2009-01-28 12:13         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4980279F.2020302@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox