[U-Boot] [PATCH 09/31] powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte

Wolfgang Denk
2009-01-28T12:00:35Z

Dear Heiko Schocher,

In message <498027CB.8030903@denx.de> you wrote:
> powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte
>
> The size of the serial RXBuffer is increased from
> 16 to 128 bytes to enable comfortable
> copy-and-paste of commands with the mouse

Why do you initialize these settins as 16 in patch N when you increase
the value in patch N+1? This makes little sense to me. Why not using
the right value right from the beginning?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Things that try to look like things often do look more like things
than things. Well-known fact. - Terry Pratchett, _Wyrd Sisters_