* [U-Boot] [PATCH 10/31] 8xx, mgsuvd: size and position of environment corrected
@ 2009-01-28 9:39 Heiko Schocher
2009-01-28 12:04 ` Wolfgang Denk
0 siblings, 1 reply; 4+ messages in thread
From: Heiko Schocher @ 2009-01-28 9:39 UTC (permalink / raw)
To: u-boot
adapted the position and size of the environment
sector to match the defines in mgcoge, kmeter1
and make them dependant of the MONITOR_LEN
instead of an absolute address
Signed-off-by: Thomas Herzmann <thomas.herzmann@keymile.com>
Signed-off-by: Heiko Schocher <hs@denx.de>
---
include/configs/mgsuvd.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/configs/mgsuvd.h b/include/configs/mgsuvd.h
index 05e770e..01f5bd3 100644
--- a/include/configs/mgsuvd.h
+++ b/include/configs/mgsuvd.h
@@ -126,13 +126,13 @@
#define CONFIG_SYS_FLASH_WRITE_TOUT 500 /* Timeout for Flash Write (in ms) */
#define CONFIG_ENV_IS_IN_FLASH 1
-#define CONFIG_ENV_OFFSET 0x40000 /* Offset of Environment Sector */
-#define CONFIG_ENV_SIZE 0x08000 /* Total Size of Environment Sector */
+#define CONFIG_ENV_OFFSET CONFIG_SYS_MONITOR_LEN
+#define CONFIG_ENV_SIZE 0x20000 /* Total Size of Environment */
#define CONFIG_ENV_SECT_SIZE 0x20000 /* Total Size of Environment Sector */
/* Address and size of Redundant Environment Sector */
#define CONFIG_ENV_OFFSET_REDUND (CONFIG_ENV_OFFSET+CONFIG_ENV_SECT_SIZE)
-#define CONFIG_ENV_SIZE_REDUND (CONFIG_ENV_SIZE)
+#define CONFIG_ENV_SIZE_REDUND (CONFIG_ENV_SIZE)
#define CONFIG_ENV_BUFFER_PRINT 1
/*-----------------------------------------------------------------------
--
1.6.0.6
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 10/31] 8xx, mgsuvd: size and position of environment corrected
2009-01-28 9:39 [U-Boot] [PATCH 10/31] 8xx, mgsuvd: size and position of environment corrected Heiko Schocher
@ 2009-01-28 12:04 ` Wolfgang Denk
2009-01-28 12:56 ` Heiko Schocher
0 siblings, 1 reply; 4+ messages in thread
From: Wolfgang Denk @ 2009-01-28 12:04 UTC (permalink / raw)
To: u-boot
Dear Heiko Schocher,
In message <498027CE.6080100@denx.de> you wrote:
> adapted the position and size of the environment
> sector to match the defines in mgcoge, kmeter1
> and make them dependant of the MONITOR_LEN
> instead of an absolute address
>
> Signed-off-by: Thomas Herzmann <thomas.herzmann@keymile.com>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> include/configs/mgsuvd.h | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/configs/mgsuvd.h b/include/configs/mgsuvd.h
> index 05e770e..01f5bd3 100644
> --- a/include/configs/mgsuvd.h
> +++ b/include/configs/mgsuvd.h
> @@ -126,13 +126,13 @@
> #define CONFIG_SYS_FLASH_WRITE_TOUT 500 /* Timeout for Flash Write (in ms) */
>
> #define CONFIG_ENV_IS_IN_FLASH 1
> -#define CONFIG_ENV_OFFSET 0x40000 /* Offset of Environment Sector */
> -#define CONFIG_ENV_SIZE 0x08000 /* Total Size of Environment Sector */
> +#define CONFIG_ENV_OFFSET CONFIG_SYS_MONITOR_LEN
> +#define CONFIG_ENV_SIZE 0x20000 /* Total Size of Environment */
> #define CONFIG_ENV_SECT_SIZE 0x20000 /* Total Size of Environment Sector */
Do you really need 128 kB environment storage? Note that this will
slow down operation a lot because it means you always have to
checksum for that much memory. The previously used value of 32 kB
should be more than sufficient for all practical purposes.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The Buddha, the Godhead, resides quite as comfortably in the circuits
of a digital computer or the gears of a cycle transmission as he does
at the top of a mountain or in the petals of a flower.
- R. Pirsig, "Zen and the Art of Motorcycle Maintenance"
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH 10/31] 8xx, mgsuvd: size and position of environment corrected
2009-01-28 12:04 ` Wolfgang Denk
@ 2009-01-28 12:56 ` Heiko Schocher
2009-01-28 13:23 ` Wolfgang Denk
0 siblings, 1 reply; 4+ messages in thread
From: Heiko Schocher @ 2009-01-28 12:56 UTC (permalink / raw)
To: u-boot
Hello Wolfgang,
Wolfgang Denk wrote:
> In message <498027CE.6080100@denx.de> you wrote:
>> adapted the position and size of the environment
>> sector to match the defines in mgcoge, kmeter1
>> and make them dependant of the MONITOR_LEN
>> instead of an absolute address
>>
>> Signed-off-by: Thomas Herzmann <thomas.herzmann@keymile.com>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> ---
>> include/configs/mgsuvd.h | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/configs/mgsuvd.h b/include/configs/mgsuvd.h
>> index 05e770e..01f5bd3 100644
>> --- a/include/configs/mgsuvd.h
>> +++ b/include/configs/mgsuvd.h
>> @@ -126,13 +126,13 @@
>> #define CONFIG_SYS_FLASH_WRITE_TOUT 500 /* Timeout for Flash Write (in ms) */
>>
>> #define CONFIG_ENV_IS_IN_FLASH 1
>> -#define CONFIG_ENV_OFFSET 0x40000 /* Offset of Environment Sector */
>> -#define CONFIG_ENV_SIZE 0x08000 /* Total Size of Environment Sector */
>> +#define CONFIG_ENV_OFFSET CONFIG_SYS_MONITOR_LEN
>> +#define CONFIG_ENV_SIZE 0x20000 /* Total Size of Environment */
>> #define CONFIG_ENV_SECT_SIZE 0x20000 /* Total Size of Environment Sector */
>
> Do you really need 128 kB environment storage? Note that this will
> slow down operation a lot because it means you always have to
> checksum for that much memory. The previously used value of 32 kB
> should be more than sufficient for all practical purposes.
As you see in the Signed-off-by, this patch comes from the manufacturer
from the board, and he needs such a big space.
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 10/31] 8xx, mgsuvd: size and position of environment corrected
2009-01-28 12:56 ` Heiko Schocher
@ 2009-01-28 13:23 ` Wolfgang Denk
0 siblings, 0 replies; 4+ messages in thread
From: Wolfgang Denk @ 2009-01-28 13:23 UTC (permalink / raw)
To: u-boot
Dear Heiko Schocher,
In message <498055F5.4010204@denx.de> you wrote:
>
> As you see in the Signed-off-by, this patch comes from the manufacturer
> from the board, and he needs such a big space.
I recom,mend you contact and ask him again, pointing out the
performance impact he is going to suffer from.
Even with the old settings (32 kB environment) - did you ever try a
"printenv" for 32 kB environment settings? I seriously doubt that
this is managable any more.
Please help the customer and prevent him from doing stupid things.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Time is a drug. Too much of it kills you.
- Terry Pratchett, _Small Gods_
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-01-28 13:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-28 9:39 [U-Boot] [PATCH 10/31] 8xx, mgsuvd: size and position of environment corrected Heiko Schocher
2009-01-28 12:04 ` Wolfgang Denk
2009-01-28 12:56 ` Heiko Schocher
2009-01-28 13:23 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox