[U-Boot] [PATCH 30/31] 8xx, km8xx: update in dts node "flash", the reg value correct.

Wolfgang Denk
2009-01-28T20:37:42Z

Dear Heiko Schocher,

please chose a better Subject.

In message <4980282A.5010001@denx.de> you wrote:

> + ulong flash_reg[3] = {0};
>
> memory_data[0] = cpu_to_be32 (bd->bi_memstart);
> memory_data[1] = cpu_to_be32 (bd->bi_memsize);
> @@ -184,6 +185,10 @@ void ft_blob_update (void *blob, bd_t *bd)
> fdt_set_node_and_value (blob, "/localbus", "ranges", flash_data,
> sizeof (flash_data));
>
> + flash_reg[2] = cpu_to_be32 (bd->bi_flashsize);
> + fdt_set_node_and_value (blob, "/localbus/flash at 0,0", "reg", flash_reg,
> + sizeof (flash_reg));

What exactly are you doing here?

This patch by itself looks pretty fishy to me. Maybe you split your
patches in a sub-optimal way?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In English, every word can be verbed. Would that it were so in our
programming languages.