From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 09/31] powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte
Date: Wed, 28 Jan 2009 13:44:41 +0100 [thread overview]
Message-ID: <49805339.8090802@denx.de> (raw)
In-Reply-To: <20090128120035.3966A832E416@gemini.denx.de>
Hello Wolfgang,
Wolfgang Denk wrote:
> In message <498027CB.8030903@denx.de> you wrote:
>> powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte
>>
>> The size of the serial RXBuffer is increased from
>> 16 to 128 bytes to enable comfortable
>> copy-and-paste of commands with the mouse
>
> Why do you initialize these settins as 16 in patch N when you increase
> the value in patch N+1? This makes little sense to me. Why not using
> the right value right from the beginning?
Because it shows a development history.
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2009-01-28 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 9:39 [U-Boot] [PATCH 09/31] powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte Heiko Schocher
2009-01-28 12:00 ` Wolfgang Denk
2009-01-28 12:44 ` Heiko Schocher [this message]
2009-01-28 13:17 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49805339.8090802@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox