public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 10/31] 8xx, mgsuvd: size and position of environment corrected
Date: Wed, 28 Jan 2009 13:56:21 +0100	[thread overview]
Message-ID: <498055F5.4010204@denx.de> (raw)
In-Reply-To: <20090128120424.CA563832E416@gemini.denx.de>

Hello Wolfgang,

Wolfgang Denk wrote:
> In message <498027CE.6080100@denx.de> you wrote:
>> adapted the position and size of the environment
>> sector to match the defines in mgcoge, kmeter1
>> and make them dependant of the MONITOR_LEN
>> instead of an absolute address
>>
>> Signed-off-by: Thomas Herzmann <thomas.herzmann@keymile.com>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> ---
>>  include/configs/mgsuvd.h |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/configs/mgsuvd.h b/include/configs/mgsuvd.h
>> index 05e770e..01f5bd3 100644
>> --- a/include/configs/mgsuvd.h
>> +++ b/include/configs/mgsuvd.h
>> @@ -126,13 +126,13 @@
>>  #define CONFIG_SYS_FLASH_WRITE_TOUT	500	/* Timeout for Flash Write (in ms)	*/
>>
>>  #define CONFIG_ENV_IS_IN_FLASH	1
>> -#define CONFIG_ENV_OFFSET		0x40000 /*   Offset   of Environment Sector	*/
>> -#define CONFIG_ENV_SIZE		0x08000 /* Total Size of Environment Sector	*/
>> +#define CONFIG_ENV_OFFSET	CONFIG_SYS_MONITOR_LEN
>> +#define CONFIG_ENV_SIZE	0x20000 /* Total Size of Environment	*/
>>  #define CONFIG_ENV_SECT_SIZE	0x20000 /* Total Size of Environment Sector	*/
> 
> Do you really need 128 kB environment storage? Note  that  this  will
> slow  down  operation  a  lot  because  it  means  you always have to
> checksum for that much memory. The previously used  value  of  32  kB
> should be more than sufficient for all practical purposes.

As you see in the Signed-off-by, this patch comes from the manufacturer
from the board, and he needs such a big space.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2009-01-28 12:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28  9:39 [U-Boot] [PATCH 10/31] 8xx, mgsuvd: size and position of environment corrected Heiko Schocher
2009-01-28 12:04 ` Wolfgang Denk
2009-01-28 12:56   ` Heiko Schocher [this message]
2009-01-28 13:23     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498055F5.4010204@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox