From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 28 Jan 2009 13:56:21 +0100 Subject: [U-Boot] [PATCH 10/31] 8xx, mgsuvd: size and position of environment corrected In-Reply-To: <20090128120424.CA563832E416@gemini.denx.de> References: <498027CE.6080100@denx.de> <20090128120424.CA563832E416@gemini.denx.de> Message-ID: <498055F5.4010204@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Wolfgang, Wolfgang Denk wrote: > In message <498027CE.6080100@denx.de> you wrote: >> adapted the position and size of the environment >> sector to match the defines in mgcoge, kmeter1 >> and make them dependant of the MONITOR_LEN >> instead of an absolute address >> >> Signed-off-by: Thomas Herzmann >> Signed-off-by: Heiko Schocher >> --- >> include/configs/mgsuvd.h | 6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/include/configs/mgsuvd.h b/include/configs/mgsuvd.h >> index 05e770e..01f5bd3 100644 >> --- a/include/configs/mgsuvd.h >> +++ b/include/configs/mgsuvd.h >> @@ -126,13 +126,13 @@ >> #define CONFIG_SYS_FLASH_WRITE_TOUT 500 /* Timeout for Flash Write (in ms) */ >> >> #define CONFIG_ENV_IS_IN_FLASH 1 >> -#define CONFIG_ENV_OFFSET 0x40000 /* Offset of Environment Sector */ >> -#define CONFIG_ENV_SIZE 0x08000 /* Total Size of Environment Sector */ >> +#define CONFIG_ENV_OFFSET CONFIG_SYS_MONITOR_LEN >> +#define CONFIG_ENV_SIZE 0x20000 /* Total Size of Environment */ >> #define CONFIG_ENV_SECT_SIZE 0x20000 /* Total Size of Environment Sector */ > > Do you really need 128 kB environment storage? Note that this will > slow down operation a lot because it means you always have to > checksum for that much memory. The previously used value of 32 kB > should be more than sufficient for all practical purposes. As you see in the Signed-off-by, this patch comes from the manufacturer from the board, and he needs such a big space. bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany