public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] Marvell 88E1118 interrupt fix
@ 2009-01-29  0:17 Ron Madrid
  2009-01-29  8:22 ` Ben Warren
  0 siblings, 1 reply; 2+ messages in thread
From: Ron Madrid @ 2009-01-29  0:17 UTC (permalink / raw)
  To: u-boot

This patch adjusts the LED control so that interrupt lines are not reading LEDs
and effectively causing indefinite interrupts to the controller.

Signed-off-by: Ron Madrid <ron_madrid@sbcglobal.net>
---
 drivers/net/tsec.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index d7da081..c9aa29d 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -1141,6 +1141,9 @@ struct phy_info phy_info_M88E1118 = {
 		{MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
 		{0x16, 0x0002, NULL}, /* Change Page Number */
 		{0x15, 0x1070, NULL}, /* Delay RGMII TX and RX */
+		{0x16, 0x0003, NULL}, /* Change Page Number */
+		{0x10, 0x021e, NULL}, /* Adjust LED control */
+		{0x16, 0x0000, NULL}, /* Change Page Number */
 		{MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
 		{MIIM_ANAR, MIIM_ANAR_INIT, NULL},
 		{MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
@@ -1152,6 +1155,7 @@ struct phy_info phy_info_M88E1118 = {
 		/* Status is read once to clear old link state */
 		{MIIM_STATUS, miim_read, NULL},
 		/* Auto-negotiate */
+		{MIIM_STATUS, miim_read, &mii_parse_sr},
 		/* Read the status */
 		{MIIM_88E1011_PHY_STATUS, miim_read,
 		 &mii_parse_88E1011_psr},
-- 
1.5.5.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] Marvell 88E1118 interrupt fix
  2009-01-29  0:17 [U-Boot] [PATCH] Marvell 88E1118 interrupt fix Ron Madrid
@ 2009-01-29  8:22 ` Ben Warren
  0 siblings, 0 replies; 2+ messages in thread
From: Ben Warren @ 2009-01-29  8:22 UTC (permalink / raw)
  To: u-boot

Ron Madrid wrote:
> This patch adjusts the LED control so that interrupt lines are not reading LEDs
> and effectively causing indefinite interrupts to the controller.
>
> Signed-off-by: Ron Madrid <ron_madrid@sbcglobal.net>
> ---
>  drivers/net/tsec.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
> index d7da081..c9aa29d 100644
> --- a/drivers/net/tsec.c
> +++ b/drivers/net/tsec.c
> @@ -1141,6 +1141,9 @@ struct phy_info phy_info_M88E1118 = {
>  		{MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
>  		{0x16, 0x0002, NULL}, /* Change Page Number */
>  		{0x15, 0x1070, NULL}, /* Delay RGMII TX and RX */
> +		{0x16, 0x0003, NULL}, /* Change Page Number */
> +		{0x10, 0x021e, NULL}, /* Adjust LED control */
> +		{0x16, 0x0000, NULL}, /* Change Page Number */
>  		{MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
>  		{MIIM_ANAR, MIIM_ANAR_INIT, NULL},
>  		{MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
> @@ -1152,6 +1155,7 @@ struct phy_info phy_info_M88E1118 = {
>  		/* Status is read once to clear old link state */
>  		{MIIM_STATUS, miim_read, NULL},
>  		/* Auto-negotiate */
> +		{MIIM_STATUS, miim_read, &mii_parse_sr},
>  		/* Read the status */
>  		{MIIM_88E1011_PHY_STATUS, miim_read,
>  		 &mii_parse_88E1011_psr},
>   
Applied to net repo.

thanks,
Ben

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-01-29  8:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-29  0:17 [U-Boot] [PATCH] Marvell 88E1118 interrupt fix Ron Madrid
2009-01-29  8:22 ` Ben Warren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox