public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Grzegorz Bernacki <gjb@semihalf.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add support for the digsy MTC board.
Date: Thu, 29 Jan 2009 09:56:32 +0100	[thread overview]
Message-ID: <49816F40.3000201@semihalf.com> (raw)
In-Reply-To: <20090128210559.8CF2A832E416@gemini.denx.de>

Wolfgang Denk wrote:
> Dear Grzegorz,
> 
> In message <12331552753467-git-send-email-gjb@semihalf.com> you wrote:
>> This is the InterControl custom device based on the MPC5200B chip.
> ...
> 
> General comment: there is a lot of code which could use a few comments
> so the reader has a chance to understand what exactly you are doing.
> 

Could you point me out which parts of code except eeprom defines needs
more comments?

> 
>> diff --git a/cpu/mpc5xxx/ide.c b/cpu/mpc5xxx/ide.c
>> index df5b4ac..07d33e3 100644
>> --- a/cpu/mpc5xxx/ide.c
>> +++ b/cpu/mpc5xxx/ide.c
>> @@ -12,7 +12,7 @@
>>   *
>>   * This program is distributed in the hope that it will be useful,
>>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>   * GNU General Public License for more details.
>>   *
>>   * You should have received a copy of the GNU General Public License
> 
> Please don't arbitrarily reformat the code.
> 

I think this tab was inserted by mistake. In u-boot code there are both
versions of license with and without this tab. Do you really want to 
leave it?

pozdrawiam,
Grzesiek

  reply	other threads:[~2009-01-29  8:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28 15:07 [U-Boot] [PATCH] Add support for the digsy MTC board Grzegorz Bernacki
2009-01-28 21:05 ` Wolfgang Denk
2009-01-29  8:56   ` Grzegorz Bernacki [this message]
2009-01-29 10:52     ` Wolfgang Denk
2009-01-29 11:09       ` Grzegorz Bernacki
2009-01-29 12:51       ` Jerry Van Baren
2009-02-03 10:05   ` Grzegorz Bernacki
  -- strict thread matches above, loose matches on Subject: below --
2009-02-12  9:21 Grzegorz Bernacki
2009-02-12  9:49 ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49816F40.3000201@semihalf.com \
    --to=gjb@semihalf.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox