From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Thu, 29 Jan 2009 10:05:26 +0100
Subject: [U-Boot] [PATCH 18/31] mpc83xx, kmeter1: add I2C, dtt,
	eeprom support
In-Reply-To: <20090128201002.18f12c92.kim.phillips@freescale.com>
References: <498027F4.3080103@denx.de>
	<20090128201002.18f12c92.kim.phillips@freescale.com>
Message-ID: <49817156.1050907@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Kim,

Kim Phillips wrote:
> On Wed, 28 Jan 2009 10:40:04 +0100
> Heiko Schocher <hs@denx.de> wrote:
> 
>> +static int board_init_i2c_busses (void)
>> +{
>> +	I2C_MUX_DEVICE *dev = NULL;
>> +	uchar	*buf;
>> +
>> +	/* Set up the Bus for the DTTs */
>> +	buf = (unsigned char *) getenv ("DTT_bus");
> 
> the environment is case sensitive; can we be more case-consistent
> with names we expect from it?

Ok.

>> +	if (buf != NULL)
>> +		dev = i2c_mux_ident_muxstring (buf);
>> +	if (dev == NULL) {
>> +		printf ("Error couldnt add Bus for DTT\n");
> 
> s/couldnt/couldn't/, add something like "please setenv dtt_bus
> <insert something reasonable here>"

Ok.

>> +		return 0;
> 
> are you sure you shouldn't be returning an error code?  otherwise this
> line is not necessary.

thanks,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany