[U-Boot] [RFC] fdt expert advice needed

Scott Wood
2009-02-02T17:09:16Z

On Sun, Feb 01, 2009 at 10:30:20PM +0100, Matthias Fuchs wrote:
> - do_fixup_by_compat_u32(blob, "ns16550", "clock-frequency", gd->uart_clk, 1);
> + off = fdt_path_offset(blob, "/plb/opb");
> + while ((off = fdt_next_node(blob, off, &ndepth)) >= 0) {
> + /*
> + * process all sub nodes and stop when we are back
> + * at the starting depth
> + */
> + if (ndepth == 0)
> + break;

Should be ndepth <= 0; it can be negative if opb is the last node under
plb to be visited.

Looks OK otherwise.

-Scott