From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ilya Yanok <yanok@emcraft.com>
Date: Thu, 05 Feb 2009 06:38:23 +0300
Subject: [U-Boot] [PATCH 2/3] dnet: driver for Dave DNET ethernet
	controller
In-Reply-To: <20090202202116.CF0BC8322908@gemini.denx.de>
References: <1233589490-14293-1-git-send-email-yanok@emcraft.com>
	<1233589490-14293-3-git-send-email-yanok@emcraft.com>
	<20090202202116.CF0BC8322908@gemini.denx.de>
Message-ID: <498A5F2F.1030603@emcraft.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang,

thanks for your review. I think I've addressed all your comments. Please
take a look on updated patches.

Wolfgang Denk wrote:
> I see. 
>
> Please do not operate on base register plus magic offset - implement a
> proper C structure instead to describe the controller hardware.
>   

I've done as you requested but I'm really in doubt why do you like it?
In the kernel offsets are preferred over C structures... And there is
nothing magical in offsets actually... we usually have offsets in specs
not C structures...

Regards, Ilya.