public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/7] OMAP3: Overo: Clean up pin mux and GPIO configuration
Date: Thu, 05 Feb 2009 20:11:59 +0100	[thread overview]
Message-ID: <498B39FF.6090808@googlemail.com> (raw)
In-Reply-To: <20090204231807.GI31498@game.jcrosoft.org>

Dear Jean-Christophe,

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 06:53 Mon 02 Feb     , Dirk Behme wrote:
>> * Make Overo GPIO114 an input for touchscreen PENDOWN
>> * Make Overo GPIO144-147 readable
>> * Make Overo EHCI pinmux match beagle rev c setup
>> * Adjust pinmux for SMSC911X network chip support
>> * Remove unnecessary GPIO setup
>> * Fix merge error in Makefile
> maybe we could split it a few more

Yes, we could. But no, we don't want to split ~20 changed lines into 
even smaller parts to

a) avoid spamming the list

b) avoid polluting the git history

> because it's not so easy to folow which modification fix what?

Well, looking at the patch, I would say that it is obvious that

* Make Overo GPIO114 an input for touchscreen PENDOWN

refers to the change which is commented with  /*GPIO_114*/\

and

* Make Overo GPIO144-147 readable

refers to the change with the comments GPIO_144, GPIO_145, GPIO_146 
and GPIO_147

and

* Make Overo EHCI pinmux match beagle rev c setup

refers to the change with USB comment

and

* Adjust pinmux for SMSC911X network chip support

refers to the change with SMSC911X comment

and

* Remove unnecessary GPIO setup

refers to the changes which remove GPIO stuff commented e.g. with "/* 
Set GPIOs */"

and

* Fix merge error in Makefile

refers to the change in Makefile
+++ u-boot-main/board/omap3/overo/Makefile

Dirk

  reply	other threads:[~2009-02-05 19:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-02  5:53 [U-Boot] [PATCH 0/7] OMAP3: Add some additional improvements and fixes Dirk Behme
2009-02-02  5:53 ` [U-Boot] [PATCH 1/7] OMAP3: Overo: Clean up pin mux and GPIO configuration Dirk Behme
2009-02-02  5:53   ` [U-Boot] [PATCH 2/7] OMAP3: Beagle: Add board revision detection Dirk Behme
2009-02-02  5:53     ` [U-Boot] [PATCH 3/7] OMAP3: Add OMAP3 auto detection Dirk Behme
2009-02-02  5:53       ` [U-Boot] [PATCH 4/7] OMAP3: Pandora: Update pin mux Dirk Behme
2009-02-02  5:53         ` [U-Boot] [PATCH 5/7] OMAP3: Add serial number based on die ID Dirk Behme
2009-02-02  5:53           ` [U-Boot] [PATCH 6/7] OMAP3: Add OMAP3 core changes for MUSB Dirk Behme
2009-02-02  5:53             ` [U-Boot] [PATCH 7/7] OMAP3: Clean up MMC code Dirk Behme
2009-02-11 22:26             ` [U-Boot] [PATCH 6/7] OMAP3: Add OMAP3 core changes for MUSB Jean-Christophe PLAGNIOL-VILLARD
2009-02-12 18:56               ` Dirk Behme
2009-02-04 23:28           ` [U-Boot] [PATCH 5/7] OMAP3: Add serial number based on die ID Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 19:14             ` Dirk Behme
2009-02-11 22:24               ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-12 18:56                 ` Dirk Behme
2009-02-11 22:34           ` Wolfgang Denk
2009-02-04 23:24         ` [U-Boot] [PATCH 4/7] OMAP3: Pandora: Update pin mux Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 19:13           ` Dirk Behme
2009-02-05 19:52             ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 20:01               ` Dirk Behme
2009-02-05 20:54                 ` Grazvydas Ignotas
2009-02-04 23:22     ` [U-Boot] [PATCH 2/7] OMAP3: Beagle: Add board revision detection Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 19:12       ` Dirk Behme
2009-02-11 22:17         ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-04 23:18   ` [U-Boot] [PATCH 1/7] OMAP3: Overo: Clean up pin mux and GPIO configuration Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 19:11     ` Dirk Behme [this message]
2009-02-04 12:46 ` [U-Boot] [PATCH 0/7] OMAP3: Add some additional improvements and fixes Jason Kridner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498B39FF.6090808@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox