[U-Boot] [PATCH 6/7] OMAP3: Add OMAP3 core changes for MUSB

Dirk Behme
2009-02-12T18:56:48Z

Dear Jean-Christophe,

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 06:53 Mon 02 Feb , Dirk Behme wrote:
>> OMAp3 core changes necessary for MUSB
>>
>> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
>>
>> ---
>> Note: OMAP3 USb code will be sent later to USB maintainer, so
>> CONFIG_MUSB isn't used anywhere yet. This will avoid
>> USB maintainer to change OMAP3 core files.
>>
>> cpu/arm_cortexa8/omap3/clock.c | 5 +++++
>> include/asm-arm/arch-omap3/cpu.h | 2 ++
>> include/asm-arm/arch-omap3/omap3.h | 11 +++++++++++
>> 3 files changed, 18 insertions(+)
>>
>> Index: u-boot-main/cpu/arm_cortexa8/omap3/clock.c
>> ===================================================================
>> --- u-boot-main.orig/cpu/arm_cortexa8/omap3/clock.c
>> +++ u-boot-main/cpu/arm_cortexa8/omap3/clock.c
>> @@ -377,5 +377,10 @@ void per_clocks_enable(void)
>> sr32(&prcm_base->fclken_per, 0, 32, FCK_PER_ON);
>> sr32(&prcm_base->iclken_per, 0, 32, ICK_PER_ON);
>>
>> +#ifdef CONFIG_MUSB
>> + /* Enable the MUSB interface clock */
>> + sr32(&prcm_base->iclken1_core, 4, 1, 0x1);
>> +#endif
>> +
> why do you enable the clock every time if you do not use it u-boot please do
> no enable it as done for the ethernet as example

Hmmh, sorry if I missed something?

But my understanding and implementation goal is to have MUSB clock
enabled only if CONFIG_MUSB is enabled (and not every time). As
mentioned above, this will be done later with an USB patch to be sent
to USB maintainer. I.e. MUSB clock will be enabled only if it is
really needed because CONFIG_MUSB is enabled (by patch to be sent later).

Dirk