From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/7] OMAP3: Pandora: Update pin mux
Date: Thu, 05 Feb 2009 21:01:36 +0100 [thread overview]
Message-ID: <498B45A0.5010206@googlemail.com> (raw)
In-Reply-To: <20090205195207.GD4580@game.jcrosoft.org>
Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 20:13 Thu 05 Feb , Dirk Behme wrote:
>> Dear Jean-Christophe,
>>
>> Jean-Christophe PLAGNIOL-VILLARD wrote:
>>> On 06:53 Mon 02 Feb , Dirk Behme wrote:
>>>> Update Pandora pin mux.
>>> for what and why?
>> Well, this is a very good example of why it is good to "use macros
>> instead of hard coded values" :)
>>
>> Looking at the changes done in this patch, thanks to the macros used, it
>> is obvious that here pulls are enabled for MMC data/cmd lines, and
>> disabled for clock line. In case you are familiar with MMC hardware
>> configuration, you should know why this is necessary.
> so please update the commit message to explain it
Sorry of being unclear: I meant that every necessary explanation is
already there if you look carefully.
Dirk
next prev parent reply other threads:[~2009-02-05 20:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 5:53 [U-Boot] [PATCH 0/7] OMAP3: Add some additional improvements and fixes Dirk Behme
2009-02-02 5:53 ` [U-Boot] [PATCH 1/7] OMAP3: Overo: Clean up pin mux and GPIO configuration Dirk Behme
2009-02-02 5:53 ` [U-Boot] [PATCH 2/7] OMAP3: Beagle: Add board revision detection Dirk Behme
2009-02-02 5:53 ` [U-Boot] [PATCH 3/7] OMAP3: Add OMAP3 auto detection Dirk Behme
2009-02-02 5:53 ` [U-Boot] [PATCH 4/7] OMAP3: Pandora: Update pin mux Dirk Behme
2009-02-02 5:53 ` [U-Boot] [PATCH 5/7] OMAP3: Add serial number based on die ID Dirk Behme
2009-02-02 5:53 ` [U-Boot] [PATCH 6/7] OMAP3: Add OMAP3 core changes for MUSB Dirk Behme
2009-02-02 5:53 ` [U-Boot] [PATCH 7/7] OMAP3: Clean up MMC code Dirk Behme
2009-02-11 22:26 ` [U-Boot] [PATCH 6/7] OMAP3: Add OMAP3 core changes for MUSB Jean-Christophe PLAGNIOL-VILLARD
2009-02-12 18:56 ` Dirk Behme
2009-02-04 23:28 ` [U-Boot] [PATCH 5/7] OMAP3: Add serial number based on die ID Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 19:14 ` Dirk Behme
2009-02-11 22:24 ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-12 18:56 ` Dirk Behme
2009-02-11 22:34 ` Wolfgang Denk
2009-02-04 23:24 ` [U-Boot] [PATCH 4/7] OMAP3: Pandora: Update pin mux Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 19:13 ` Dirk Behme
2009-02-05 19:52 ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 20:01 ` Dirk Behme [this message]
2009-02-05 20:54 ` Grazvydas Ignotas
2009-02-04 23:22 ` [U-Boot] [PATCH 2/7] OMAP3: Beagle: Add board revision detection Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 19:12 ` Dirk Behme
2009-02-11 22:17 ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-04 23:18 ` [U-Boot] [PATCH 1/7] OMAP3: Overo: Clean up pin mux and GPIO configuration Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 19:11 ` Dirk Behme
2009-02-04 12:46 ` [U-Boot] [PATCH 0/7] OMAP3: Add some additional improvements and fixes Jason Kridner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498B45A0.5010206@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox