From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Behme Date: Thu, 05 Feb 2009 21:01:36 +0100 Subject: [U-Boot] [PATCH 4/7] OMAP3: Pandora: Update pin mux In-Reply-To: <20090205195207.GD4580@game.jcrosoft.org> References: <1233554011-30084-1-git-send-email-dirk.behme@googlemail.com> <1233554011-30084-2-git-send-email-dirk.behme@googlemail.com> <1233554011-30084-3-git-send-email-dirk.behme@googlemail.com> <1233554011-30084-4-git-send-email-dirk.behme@googlemail.com> <1233554011-30084-5-git-send-email-dirk.behme@googlemail.com> <20090204232412.GK31498@game.jcrosoft.org> <498B3A54.9010907@googlemail.com> <20090205195207.GD4580@game.jcrosoft.org> Message-ID: <498B45A0.5010206@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Jean-Christophe PLAGNIOL-VILLARD wrote: > On 20:13 Thu 05 Feb , Dirk Behme wrote: >> Dear Jean-Christophe, >> >> Jean-Christophe PLAGNIOL-VILLARD wrote: >>> On 06:53 Mon 02 Feb , Dirk Behme wrote: >>>> Update Pandora pin mux. >>> for what and why? >> Well, this is a very good example of why it is good to "use macros >> instead of hard coded values" :) >> >> Looking at the changes done in this patch, thanks to the macros used, it >> is obvious that here pulls are enabled for MMC data/cmd lines, and >> disabled for clock line. In case you are familiar with MMC hardware >> configuration, you should know why this is necessary. > so please update the commit message to explain it Sorry of being unclear: I meant that every necessary explanation is already there if you look carefully. Dirk