From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anatolij Gustschin <agust@denx.de>
Date: Fri, 06 Feb 2009 01:19:37 +0100
Subject: [U-Boot] [PATCH 4/9 v2] A driver for the S6E63D6 SPI display
 controller from Samsung
In-Reply-To: <Pine.LNX.4.64.0902051745280.5553@axis700.grange>
References: <Pine.LNX.4.64.0902041532100.6279@axis700.grange>
	<Pine.LNX.4.64.0902051225190.5553@axis700.grange>
	<Pine.LNX.4.64.0902051304210.5553@axis700.grange>
	<498B16F1.7080800@denx.de>
	<Pine.LNX.4.64.0902051745280.5553@axis700.grange>
Message-ID: <498B8219.3010202@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Guennadi Liakhovetski wrote:

>>> +	err = spi_xfer(data->slave, 8, &buf8, &buf_in, SPI_XFER_BEGIN);
>>> +	if (err)
>>> +		return err;
>>> +	return spi_xfer(data->slave, 16, &buf16, &buf_in, SPI_XFER_END);
>> please add an empty line between two return statements here, Thanks!
> 
> Is this also required by CodingStyle?

not explicitly, but IMHO, it slightly improves readability and
also will be consistent with style used in s6e63d6_init() some
lines below. It seems to be preferred style in other code, too.

Best regards,
Anatolij