public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ilya Yanok <yanok@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3][v3] dnet: driver for Dave DNET ethernet controller
Date: Mon, 09 Feb 2009 20:21:16 +0300	[thread overview]
Message-ID: <4990660C.8080705@emcraft.com> (raw)
In-Reply-To: <20090209142753.B1F218322908@gemini.denx.de>

Hi Wolfgang,

Wolfgang Denk wrote:
>>>> +    u32 TX_JUMBO_CNT;
>>>> +    u32 TX_BYTE_CNT;
>>>> +} __attribute__((packed));
>>>>   
>>>>         
>>> Why is this packed?  All fields are 32-bit aligned already.
>>>       
>> Generally, I prefer declaring such structures with ((packed)) regardless
>> of if it's really do something. Just to show that it should be packed.
>>     
>
> Can you please verify that it works as well without the "packed", and
> if it does (as expected) resubmit without it?
>   

Ok. It works as expected. I'll post the updated patch soon.

Regards, Ilya.

  reply	other threads:[~2009-02-09 17:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-07 21:59 [U-Boot] [PATCH 0/3][v3] qong: support for Dave/DENX QongEVB-LITE Ilya Yanok
2009-02-07 21:59 ` [U-Boot] [PATCH 1/3][v3] mx31: add GPIO registers definitions Ilya Yanok
2009-02-07 22:30   ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-07 21:59 ` [U-Boot] [PATCH 2/3][v3] dnet: driver for Dave DNET ethernet controller Ilya Yanok
2009-02-09  6:59   ` Ben Warren
2009-02-09 12:39     ` Ilya Yanok
2009-02-09 14:27       ` Wolfgang Denk
2009-02-09 17:21         ` Ilya Yanok [this message]
2009-02-09 17:24         ` [U-Boot] [PATCH 2/3][v4] " Ilya Yanok
2009-02-09 17:44         ` [U-Boot] [PATCH 2/3][v3] " Ilya Yanok
2009-02-09 17:45         ` [U-Boot] [PATCH 2/3][v5] " Ilya Yanok
2009-02-09 17:51           ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-09 17:55             ` Ben Warren
2009-02-07 21:59 ` [U-Boot] [PATCH 3/3][v3] qong: support for Dave/DENX QongEVB-LITE board Ilya Yanok
2009-02-09 23:25 ` [U-Boot] [PATCH 0/3][v3] qong: support for Dave/DENX QongEVB-LITE Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4990660C.8080705@emcraft.com \
    --to=yanok@emcraft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox