From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ilya Yanok <yanok@emcraft.com>
Date: Mon, 09 Feb 2009 20:21:16 +0300
Subject: [U-Boot] [PATCH 2/3][v3] dnet: driver for Dave DNET ethernet
 controller
In-Reply-To: <20090209142753.B1F218322908@gemini.denx.de>
References: <1234043985-9820-1-git-send-email-yanok@emcraft.com>
	<1234043985-9820-3-git-send-email-yanok@emcraft.com>
	<498FD452.2010501@gmail.com> <49902403.2010406@emcraft.com>
	<20090209142753.B1F218322908@gemini.denx.de>
Message-ID: <4990660C.8080705@emcraft.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

Wolfgang Denk wrote:
>>>> +    u32 TX_JUMBO_CNT;
>>>> +    u32 TX_BYTE_CNT;
>>>> +} __attribute__((packed));
>>>>   
>>>>         
>>> Why is this packed?  All fields are 32-bit aligned already.
>>>       
>> Generally, I prefer declaring such structures with ((packed)) regardless
>> of if it's really do something. Just to show that it should be packed.
>>     
>
> Can you please verify that it works as well without the "packed", and
> if it does (as expected) resubmit without it?
>   

Ok. It works as expected. I'll post the updated patch soon.

Regards, Ilya.