From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Mon, 09 Feb 2009 14:03:45 -0800
Subject: [U-Boot] [PATCH 1/2] net: Sort Makefile labels
In-Reply-To: <20090209200937.0B93E8322908@gemini.denx.de>
References: <1231154714-15799-1-git-send-email-monstr@monstr.eu>
	<d4fd46d3b2d27747b728da37fad3ebca3732d837.1231154122.git.monstr@monstr.eu>
	<20090209200937.0B93E8322908@gemini.denx.de>
Message-ID: <4990A841.3000705@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:
> Dear monstr at monstr.eu,
>
> In message <d4fd46d3b2d27747b728da37fad3ebca3732d837.1231154122.git.monstr@monstr.eu> you wrote:
>   
>> From: Michal Simek <monstr@monstr.eu>
>>
>>
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>> ---
>>  drivers/net/Makefile |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
>> index 631336a..128dc11 100644
>> --- a/drivers/net/Makefile
>> +++ b/drivers/net/Makefile
>> @@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk
>>  LIB	:= $(obj)libnet.a
>>  
>>  COBJS-$(CONFIG_DRIVER_3C589) += 3c589.o
>> +COBJS-$(CONFIG_PPC4xx_EMAC) += 4xx_enet.o
>>  COBJS-$(CONFIG_DRIVER_AX88180) += ax88180.o
>>     
>
> What makes you think that CONFIG_PPC4xx_EMAC has a good place between
> CONFIG_DRIVER_3C589 and CONFIG_DRIVER_AX88180?
>
>   
>>  COBJS-$(CONFIG_BFIN_MAC) += bfin_mac.o
>> @@ -54,11 +55,11 @@ COBJS-$(CONFIG_NS8382X) += ns8382x.o
>>  COBJS-$(CONFIG_DRIVER_NS9750_ETHERNET) += ns9750_eth.o
>>  COBJS-$(CONFIG_PCNET) += pcnet.o
>>  COBJS-$(CONFIG_PLB2800_ETHER) += plb2800_eth.o
>> -COBJS-$(CONFIG_PPC4xx_EMAC) += 4xx_enet.o
>>     
>
> that was ok here.
>
>   
>>  COBJS-$(CONFIG_DRIVER_RTL8019) += rtl8019.o
>>     
>
> ...while this isn't.
>
>   
>>  COBJS-$(CONFIG_RTL8139) += rtl8139.o
>>  COBJS-$(CONFIG_RTL8169) += rtl8169.o
>>  COBJS-$(CONFIG_DRIVER_S3C4510_ETH) += s3c4510b_eth.o
>> +COBJS-$(CONFIG_SH_ETHER) += sh_eth.o
>>  COBJS-$(CONFIG_DRIVER_SMC91111) += smc91111.o
>>  COBJS-$(CONFIG_DRIVER_SMC911X) += smc911x.o
>>  COBJS-$(CONFIG_TIGON3) += tigon3.o bcm570x_autoneg.o 5701rls.o
>> @@ -68,7 +69,6 @@ COBJS-$(CONFIG_ULI526X) += uli526x.o
>>  COBJS-$(CONFIG_VSC7385_ENET) += vsc7385.o
>>  COBJS-$(CONFIG_XILINX_EMAC) += xilinx_emac.o
>>  COBJS-$(CONFIG_XILINX_EMACLITE) += xilinx_emaclite.o
>> -COBJS-$(CONFIG_SH_ETHER) += sh_eth.o
>>     
>
> Actually we should perform a global s/CONFIG_DRIVER_/CONFIG_/, me
> thinks.
>
>   
Agreed.  Can you do it Michal, or should I (for net, anyway)?
> Best regards,
>
> Wolfgang Denk
>
>   
regards,
Ben