[U-Boot] [PATCH 2/3] dnet: driver for Dave DNET ethernet controller

Ilya Yanok
2009-02-05T03:38:23Z

Dear Wolfgang,

thanks for your review. I think I've addressed all your comments. Please
take a look on updated patches.

Wolfgang Denk wrote:
> I see.
>
> Please do not operate on base register plus magic offset - implement a
> proper C structure instead to describe the controller hardware.
>

I've done as you requested but I'm really in doubt why do you like it?
In the kernel offsets are preferred over C structures... And there is
nothing magical in offsets actually... we usually have offsets in specs
not C structures...

Regards, Ilya.