[U-Boot] [PATCH 1/3] mx31: add GPIO registers definitions

Wolfgang Denk
2009-02-02T20:11:32Z

Dear Ilya Yanok,

In message <1233589490-14293-2-git-send-email-yanok@emcraft.com> you wrote:
> Added definitions for i.MX31 processor GPIO registers.
>
> Signed-off-by: Ilya Yanok <yanok@emcraft.com>
> ---
> include/asm-arm/arch-mx31/mx31-regs.h | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/include/asm-arm/arch-mx31/mx31-regs.h b/include/asm-arm/arch-mx31/mx31-regs.h
> index b04a718..939bdd3 100644
> --- a/include/asm-arm/arch-mx31/mx31-regs.h
> +++ b/include/asm-arm/arch-mx31/mx31-regs.h
> @@ -87,6 +87,16 @@
> #define WDOG_BASE 0x53FDC000
>
> /*
> + * GPIO
> + */
> +#define GPIO1_BASE (0x53FCC000)
> +#define GPIO2_BASE (0x53FD0000)
> +#define GPIO3_BASE (0x53FA4000)
> +#define GPIO_DR (0x00000000)
> +#define GPIO_GDIR (0x00000004)
> +#define GPIO_PSR (0x00000008)

No need for parens around simple constants.

But please add a few comments what all these mean/

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every revolutionary idea - in science, politics, art, or whatever -
evokes three stages of reaction in a hearer:
1. It is completely impossible - don't waste my time.
2. It is possible, but it is not worth doing.
3. I said it was a good idea all along.