From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/7] OMAP3: Add OMAP3 core changes for MUSB
Date: Thu, 12 Feb 2009 19:56:48 +0100 [thread overview]
Message-ID: <499470F0.6090300@googlemail.com> (raw)
In-Reply-To: <20090211222634.GD11687@game.jcrosoft.org>
Dear Jean-Christophe,
Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 06:53 Mon 02 Feb , Dirk Behme wrote:
>> OMAp3 core changes necessary for MUSB
>>
>> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
>>
>> ---
>> Note: OMAP3 USb code will be sent later to USB maintainer, so
>> CONFIG_MUSB isn't used anywhere yet. This will avoid
>> USB maintainer to change OMAP3 core files.
>>
>> cpu/arm_cortexa8/omap3/clock.c | 5 +++++
>> include/asm-arm/arch-omap3/cpu.h | 2 ++
>> include/asm-arm/arch-omap3/omap3.h | 11 +++++++++++
>> 3 files changed, 18 insertions(+)
>>
>> Index: u-boot-main/cpu/arm_cortexa8/omap3/clock.c
>> ===================================================================
>> --- u-boot-main.orig/cpu/arm_cortexa8/omap3/clock.c
>> +++ u-boot-main/cpu/arm_cortexa8/omap3/clock.c
>> @@ -377,5 +377,10 @@ void per_clocks_enable(void)
>> sr32(&prcm_base->fclken_per, 0, 32, FCK_PER_ON);
>> sr32(&prcm_base->iclken_per, 0, 32, ICK_PER_ON);
>>
>> +#ifdef CONFIG_MUSB
>> + /* Enable the MUSB interface clock */
>> + sr32(&prcm_base->iclken1_core, 4, 1, 0x1);
>> +#endif
>> +
> why do you enable the clock every time if you do not use it u-boot please do
> no enable it as done for the ethernet as example
Hmmh, sorry if I missed something?
But my understanding and implementation goal is to have MUSB clock
enabled only if CONFIG_MUSB is enabled (and not every time). As
mentioned above, this will be done later with an USB patch to be sent
to USB maintainer. I.e. MUSB clock will be enabled only if it is
really needed because CONFIG_MUSB is enabled (by patch to be sent later).
Dirk
next prev parent reply other threads:[~2009-02-12 18:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 5:53 [U-Boot] [PATCH 0/7] OMAP3: Add some additional improvements and fixes Dirk Behme
2009-02-02 5:53 ` [U-Boot] [PATCH 1/7] OMAP3: Overo: Clean up pin mux and GPIO configuration Dirk Behme
2009-02-02 5:53 ` [U-Boot] [PATCH 2/7] OMAP3: Beagle: Add board revision detection Dirk Behme
2009-02-02 5:53 ` [U-Boot] [PATCH 3/7] OMAP3: Add OMAP3 auto detection Dirk Behme
2009-02-02 5:53 ` [U-Boot] [PATCH 4/7] OMAP3: Pandora: Update pin mux Dirk Behme
2009-02-02 5:53 ` [U-Boot] [PATCH 5/7] OMAP3: Add serial number based on die ID Dirk Behme
2009-02-02 5:53 ` [U-Boot] [PATCH 6/7] OMAP3: Add OMAP3 core changes for MUSB Dirk Behme
2009-02-02 5:53 ` [U-Boot] [PATCH 7/7] OMAP3: Clean up MMC code Dirk Behme
2009-02-11 22:26 ` [U-Boot] [PATCH 6/7] OMAP3: Add OMAP3 core changes for MUSB Jean-Christophe PLAGNIOL-VILLARD
2009-02-12 18:56 ` Dirk Behme [this message]
2009-02-04 23:28 ` [U-Boot] [PATCH 5/7] OMAP3: Add serial number based on die ID Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 19:14 ` Dirk Behme
2009-02-11 22:24 ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-12 18:56 ` Dirk Behme
2009-02-11 22:34 ` Wolfgang Denk
2009-02-04 23:24 ` [U-Boot] [PATCH 4/7] OMAP3: Pandora: Update pin mux Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 19:13 ` Dirk Behme
2009-02-05 19:52 ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 20:01 ` Dirk Behme
2009-02-05 20:54 ` Grazvydas Ignotas
2009-02-04 23:22 ` [U-Boot] [PATCH 2/7] OMAP3: Beagle: Add board revision detection Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 19:12 ` Dirk Behme
2009-02-11 22:17 ` Jean-Christophe PLAGNIOL-VILLARD
2009-02-04 23:18 ` [U-Boot] [PATCH 1/7] OMAP3: Overo: Clean up pin mux and GPIO configuration Jean-Christophe PLAGNIOL-VILLARD
2009-02-05 19:11 ` Dirk Behme
2009-02-04 12:46 ` [U-Boot] [PATCH 0/7] OMAP3: Add some additional improvements and fixes Jason Kridner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499470F0.6090300@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox