From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Grandegger <wg@grandegger.com>
Date: Fri, 13 Feb 2009 22:22:10 +0100
Subject: [U-Boot] [PATCH v2 3/5] Add support for TQM-specific
 chip	select logic to FSL-UPM
In-Reply-To: <20090213205952.GB25384@ld0162-tx32.am.freescale.net>
References: <20090211173819.399651539@grandegger.com>	<20090211173819.740828969@grandegger.com>
	<20090213205952.GB25384@ld0162-tx32.am.freescale.net>
Message-ID: <4995E482.30603@grandegger.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Scott Wood wrote:
> On Wed, Feb 11, 2009 at 06:38:22PM +0100, Wolfgang Grandegger wrote:
>> Index: u-boot/drivers/mtd/nand/fsl_upm.c
>> ===================================================================
>> --- u-boot.orig/drivers/mtd/nand/fsl_upm.c
>> +++ u-boot/drivers/mtd/nand/fsl_upm.c
>> @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info
>>  	mar = cmd << (32 - fun->width);
>>  	io_addr = fun->upm.io_addr;
>>  #if CONFIG_SYS_NAND_MAX_CHIPS > 1
>> -	if (fun->chip_nr > 0)
>> +	if (fun->chip_nr > 0) {
>>  		io_addr += fun->chip_offset * fun->chip_nr;
>> +		if (fun->upm_mar_chip_offset)
>> +			mar |= fun->upm_mar_chip_offset * fun->chip_nr;
>> +	}
> 
> Any particular reason not to drop the > 0 conditional?

No, apart from saving some space. Should I send an updated patch?

Wolfgang.