From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM
Date: Fri, 13 Feb 2009 15:35:23 -0600 [thread overview]
Message-ID: <4995E79B.6000702@freescale.com> (raw)
In-Reply-To: <4995E482.30603@grandegger.com>
Wolfgang Grandegger wrote:
> Scott Wood wrote:
>> On Wed, Feb 11, 2009 at 06:38:22PM +0100, Wolfgang Grandegger wrote:
>>> Index: u-boot/drivers/mtd/nand/fsl_upm.c
>>> ===================================================================
>>> --- u-boot.orig/drivers/mtd/nand/fsl_upm.c
>>> +++ u-boot/drivers/mtd/nand/fsl_upm.c
>>> @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info
>>> mar = cmd << (32 - fun->width);
>>> io_addr = fun->upm.io_addr;
>>> #if CONFIG_SYS_NAND_MAX_CHIPS > 1
>>> - if (fun->chip_nr > 0)
>>> + if (fun->chip_nr > 0) {
>>> io_addr += fun->chip_offset * fun->chip_nr;
>>> + if (fun->upm_mar_chip_offset)
>>> + mar |= fun->upm_mar_chip_offset * fun->chip_nr;
>>> + }
>> Any particular reason not to drop the > 0 conditional?
>
> No, apart from saving some space. Should I send an updated patch?
BTW, it seems to me that the conditional adds to the image size, rather
than reducing it...
-Scott
next prev parent reply other threads:[~2009-02-13 21:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 17:38 [U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548 Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 1/5] Enable multi chip support in the NAND layer Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 2/5] Add multi chip support to the FSL-UPM driver Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM Wolfgang Grandegger
2009-02-13 20:59 ` Scott Wood
2009-02-13 21:22 ` Wolfgang Grandegger
2009-02-13 21:30 ` Scott Wood
2009-02-13 21:35 ` Scott Wood [this message]
2009-02-11 17:38 ` [U-Boot] [PATCH v2 4/5] Add wait flags to support board/chip specific delays Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 5/5] Add multi-chip NAND support for the TQM8548 modules Wolfgang Grandegger
2009-02-13 20:58 ` [U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548 Scott Wood
[not found] ` <bb70857e0902160123r5b4747b2naaf79ac418b1606e@mail.gmail.com>
2009-02-16 9:28 ` [U-Boot] Fwd: " arun sharma
2009-02-16 13:08 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4995E79B.6000702@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox