[U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548

[U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548

[Wolfgang Grandegger]

The following patch series intends to support the Micron multi-chip
NAND device MT29F8G08FAB on the TQM8548 modules from TQ-Components.
To offer this multi-chip device as one single device to the user,
multi-chip device has been added to the MTD NAND layer and the
FSL-UPM-NAND driver.

The TQM8548 support is based on the following patch series sent
a few minutes ago:

[PATCH 0/8] MPC85xx: Support for TQM8548-AG and TQM8548-BE

Wolfgang.

[U-Boot] [PATCH v2 1/5] Enable multi chip support in the NAND layer

[Wolfgang Grandegger]

An embedded and charset-unspecified text was scrubbed...
Name: nand-multi-chip-support.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20090211/87dff9c3/attachment.txt 

[U-Boot] [PATCH v2 2/5] Add multi chip support to the FSL-UPM driver

[Wolfgang Grandegger]

An embedded and charset-unspecified text was scrubbed...
Name: nand-fsl-upm-multi-chip-support.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20090211/5df3de58/attachment.txt 

[U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM

[Wolfgang Grandegger]

An embedded and charset-unspecified text was scrubbed...
Name: nand-fsl-upm-tqm-cs-support.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20090211/15fb6ce5/attachment.txt 

[U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM

[Scott Wood]

On Wed, Feb 11, 2009 at 06:38:22PM +0100, Wolfgang Grandegger wrote:
> Index: u-boot/drivers/mtd/nand/fsl_upm.c
> ===================================================================
> --- u-boot.orig/drivers/mtd/nand/fsl_upm.c
> +++ u-boot/drivers/mtd/nand/fsl_upm.c
> @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info
>  	mar = cmd << (32 - fun->width);
>  	io_addr = fun->upm.io_addr;
>  #if CONFIG_SYS_NAND_MAX_CHIPS > 1
> -	if (fun->chip_nr > 0)
> +	if (fun->chip_nr > 0) {
>  		io_addr += fun->chip_offset * fun->chip_nr;
> +		if (fun->upm_mar_chip_offset)
> +			mar |= fun->upm_mar_chip_offset * fun->chip_nr;
> +	}

Any particular reason not to drop the > 0 conditional?

-Scott

[U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM

[Wolfgang Grandegger]

Scott Wood wrote:
> On Wed, Feb 11, 2009 at 06:38:22PM +0100, Wolfgang Grandegger wrote:
>> Index: u-boot/drivers/mtd/nand/fsl_upm.c
>> ===================================================================
>> --- u-boot.orig/drivers/mtd/nand/fsl_upm.c
>> +++ u-boot/drivers/mtd/nand/fsl_upm.c
>> @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info
>>  	mar = cmd << (32 - fun->width);
>>  	io_addr = fun->upm.io_addr;
>>  #if CONFIG_SYS_NAND_MAX_CHIPS > 1
>> -	if (fun->chip_nr > 0)
>> +	if (fun->chip_nr > 0) {
>>  		io_addr += fun->chip_offset * fun->chip_nr;
>> +		if (fun->upm_mar_chip_offset)
>> +			mar |= fun->upm_mar_chip_offset * fun->chip_nr;
>> +	}
> 
> Any particular reason not to drop the > 0 conditional?

No, apart from saving some space. Should I send an updated patch?

Wolfgang.

[U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM

[Scott Wood]

Wolfgang Grandegger wrote:
> Scott Wood wrote:
>> On Wed, Feb 11, 2009 at 06:38:22PM +0100, Wolfgang Grandegger wrote:
>>> Index: u-boot/drivers/mtd/nand/fsl_upm.c
>>> ===================================================================
>>> --- u-boot.orig/drivers/mtd/nand/fsl_upm.c
>>> +++ u-boot/drivers/mtd/nand/fsl_upm.c
>>> @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info
>>>  	mar = cmd << (32 - fun->width);
>>>  	io_addr = fun->upm.io_addr;
>>>  #if CONFIG_SYS_NAND_MAX_CHIPS > 1
>>> -	if (fun->chip_nr > 0)
>>> +	if (fun->chip_nr > 0) {
>>>  		io_addr += fun->chip_offset * fun->chip_nr;
>>> +		if (fun->upm_mar_chip_offset)
>>> +			mar |= fun->upm_mar_chip_offset * fun->chip_nr;
>>> +	}
>> Any particular reason not to drop the > 0 conditional?
> 
> No, apart from saving some space. Should I send an updated patch?

No, I've applied it.  You can send a follow-up patch if you like.

-Scott

[U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM

[Scott Wood]

Wolfgang Grandegger wrote:
> Scott Wood wrote:
>> On Wed, Feb 11, 2009 at 06:38:22PM +0100, Wolfgang Grandegger wrote:
>>> Index: u-boot/drivers/mtd/nand/fsl_upm.c
>>> ===================================================================
>>> --- u-boot.orig/drivers/mtd/nand/fsl_upm.c
>>> +++ u-boot/drivers/mtd/nand/fsl_upm.c
>>> @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info
>>>  	mar = cmd << (32 - fun->width);
>>>  	io_addr = fun->upm.io_addr;
>>>  #if CONFIG_SYS_NAND_MAX_CHIPS > 1
>>> -	if (fun->chip_nr > 0)
>>> +	if (fun->chip_nr > 0) {
>>>  		io_addr += fun->chip_offset * fun->chip_nr;
>>> +		if (fun->upm_mar_chip_offset)
>>> +			mar |= fun->upm_mar_chip_offset * fun->chip_nr;
>>> +	}
>> Any particular reason not to drop the > 0 conditional?
> 
> No, apart from saving some space. Should I send an updated patch?

BTW, it seems to me that the conditional adds to the image size, rather 
than reducing it...

-Scott

[U-Boot] [PATCH v2 4/5] Add wait flags to support board/chip specific delays

[Wolfgang Grandegger]

An embedded and charset-unspecified text was scrubbed...
Name: nand-fsl-upm-wait-flags.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20090211/2ff2c9e9/attachment.txt 

[U-Boot] [PATCH v2 5/5] Add multi-chip NAND support for the TQM8548 modules

[Wolfgang Grandegger]

An embedded and charset-unspecified text was scrubbed...
Name: nand-fsl-upm-tqm8548-support.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20090211/861d1cde/attachment.txt 

[U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548

[Scott Wood]

On Wed, Feb 11, 2009 at 06:38:19PM +0100, Wolfgang Grandegger wrote:
> The following patch series intends to support the Micron multi-chip
> NAND device MT29F8G08FAB on the TQM8548 modules from TQ-Components.
> To offer this multi-chip device as one single device to the user,
> multi-chip device has been added to the MTD NAND layer and the
> FSL-UPM-NAND driver.
> 
> The TQM8548 support is based on the following patch series sent
> a few minutes ago:
> 
> [PATCH 0/8] MPC85xx: Support for TQM8548-AG and TQM8548-BE
> 
> Wolfgang.

Applied 1-5 to u-boot-nand-flash/next, thanks!

-Scott

[U-Boot] Fwd: [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548

[arun sharma]

>* Index: u-boot/drivers/mtd/nand/fsl_upm.c
*>* ===================================================================
*>* --- u-boot.orig/drivers/mtd/nand/fsl_upm.c
*>* +++ u-boot/drivers/mtd/nand/fsl_upm.c
*>* @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info
*>*  	mar = cmd << (32 - fun->width);
*>*  	io_addr = fun->upm.io_addr;
*>*  #if CONFIG_SYS_NAND_MAX_CHIPS > 1
*>* -	if (fun->chip_nr > 0)
*>* +	if (fun->chip_nr > 0) {
*>*  		io_addr += fun->chip_offset * fun->chip_nr;
*>* +		if (fun->upm_mar_chip_offset)
*>* +			mar |= fun->upm_mar_chip_offset * fun->chip_nr;
*>* +	}
*
above patch is not suitable for 832x becuase mar register has only 26
bit (6 bit are resrved)
what should be done



On Sat, Feb 14, 2009 at 2:28 AM, Scott Wood <scottwood@freescale.com> wrote:

> On Wed, Feb 11, 2009 at 06:38:19PM +0100, Wolfgang Grandegger wrote:
> > The following patch series intends to support the Micron multi-chip
> > NAND device MT29F8G08FAB on the TQM8548 modules from TQ-Components.
> > To offer this multi-chip device as one single device to the user,
> > multi-chip device has been added to the MTD NAND layer and the
> > FSL-UPM-NAND driver.
> >
> > The TQM8548 support is based on the following patch series sent
> > a few minutes ago:
> >
> > [PATCH 0/8] MPC85xx: Support for TQM8548-AG and TQM8548-BE
> >
> > Wolfgang.
>
> Applied 1-5 to u-boot-nand-flash/next, thanks!
>
> -Scott
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

[U-Boot] Fwd: [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548

[Wolfgang Grandegger]

arun sharma wrote:
>> * Index: u-boot/drivers/mtd/nand/fsl_upm.c
> *>* ===================================================================
> *>* --- u-boot.orig/drivers/mtd/nand/fsl_upm.c
> *>* +++ u-boot/drivers/mtd/nand/fsl_upm.c
> *>* @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info
> *>*  	mar = cmd << (32 - fun->width);
> *>*  	io_addr = fun->upm.io_addr;
> *>*  #if CONFIG_SYS_NAND_MAX_CHIPS > 1
> *>* -	if (fun->chip_nr > 0)
> *>* +	if (fun->chip_nr > 0) {
> *>*  		io_addr += fun->chip_offset * fun->chip_nr;
> *>* +		if (fun->upm_mar_chip_offset)
> *>* +			mar |= fun->upm_mar_chip_offset * fun->chip_nr;
> *>* +	}
> *
> above patch is not suitable for 832x becuase mar register has only 26
> bit (6 bit are resrved)
> what should be done

Simply do not define fun->upm_mar_chip_offset in your BSP code. It is
used on the TQM8548 modules to driver some board-specific chip select
logic. Anyhow, do you need to support a multi-chip (multi-die) device all?

Wolfgang.