* [U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548
@ 2009-02-11 17:38 Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 1/5] Enable multi chip support in the NAND layer Wolfgang Grandegger
` (5 more replies)
0 siblings, 6 replies; 13+ messages in thread
From: Wolfgang Grandegger @ 2009-02-11 17:38 UTC (permalink / raw)
To: u-boot
The following patch series intends to support the Micron multi-chip
NAND device MT29F8G08FAB on the TQM8548 modules from TQ-Components.
To offer this multi-chip device as one single device to the user,
multi-chip device has been added to the MTD NAND layer and the
FSL-UPM-NAND driver.
The TQM8548 support is based on the following patch series sent
a few minutes ago:
[PATCH 0/8] MPC85xx: Support for TQM8548-AG and TQM8548-BE
Wolfgang.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v2 1/5] Enable multi chip support in the NAND layer
2009-02-11 17:38 [U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548 Wolfgang Grandegger
@ 2009-02-11 17:38 ` Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 2/5] Add multi chip support to the FSL-UPM driver Wolfgang Grandegger
` (4 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Wolfgang Grandegger @ 2009-02-11 17:38 UTC (permalink / raw)
To: u-boot
An embedded and charset-unspecified text was scrubbed...
Name: nand-multi-chip-support.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20090211/87dff9c3/attachment.txt
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v2 2/5] Add multi chip support to the FSL-UPM driver
2009-02-11 17:38 [U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548 Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 1/5] Enable multi chip support in the NAND layer Wolfgang Grandegger
@ 2009-02-11 17:38 ` Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM Wolfgang Grandegger
` (3 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Wolfgang Grandegger @ 2009-02-11 17:38 UTC (permalink / raw)
To: u-boot
An embedded and charset-unspecified text was scrubbed...
Name: nand-fsl-upm-multi-chip-support.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20090211/5df3de58/attachment.txt
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM
2009-02-11 17:38 [U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548 Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 1/5] Enable multi chip support in the NAND layer Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 2/5] Add multi chip support to the FSL-UPM driver Wolfgang Grandegger
@ 2009-02-11 17:38 ` Wolfgang Grandegger
2009-02-13 20:59 ` Scott Wood
2009-02-11 17:38 ` [U-Boot] [PATCH v2 4/5] Add wait flags to support board/chip specific delays Wolfgang Grandegger
` (2 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Wolfgang Grandegger @ 2009-02-11 17:38 UTC (permalink / raw)
To: u-boot
An embedded and charset-unspecified text was scrubbed...
Name: nand-fsl-upm-tqm-cs-support.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20090211/15fb6ce5/attachment.txt
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v2 4/5] Add wait flags to support board/chip specific delays
2009-02-11 17:38 [U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548 Wolfgang Grandegger
` (2 preceding siblings ...)
2009-02-11 17:38 ` [U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM Wolfgang Grandegger
@ 2009-02-11 17:38 ` Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 5/5] Add multi-chip NAND support for the TQM8548 modules Wolfgang Grandegger
2009-02-13 20:58 ` [U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548 Scott Wood
5 siblings, 0 replies; 13+ messages in thread
From: Wolfgang Grandegger @ 2009-02-11 17:38 UTC (permalink / raw)
To: u-boot
An embedded and charset-unspecified text was scrubbed...
Name: nand-fsl-upm-wait-flags.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20090211/2ff2c9e9/attachment.txt
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v2 5/5] Add multi-chip NAND support for the TQM8548 modules
2009-02-11 17:38 [U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548 Wolfgang Grandegger
` (3 preceding siblings ...)
2009-02-11 17:38 ` [U-Boot] [PATCH v2 4/5] Add wait flags to support board/chip specific delays Wolfgang Grandegger
@ 2009-02-11 17:38 ` Wolfgang Grandegger
2009-02-13 20:58 ` [U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548 Scott Wood
5 siblings, 0 replies; 13+ messages in thread
From: Wolfgang Grandegger @ 2009-02-11 17:38 UTC (permalink / raw)
To: u-boot
An embedded and charset-unspecified text was scrubbed...
Name: nand-fsl-upm-tqm8548-support.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20090211/861d1cde/attachment.txt
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548
2009-02-11 17:38 [U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548 Wolfgang Grandegger
` (4 preceding siblings ...)
2009-02-11 17:38 ` [U-Boot] [PATCH v2 5/5] Add multi-chip NAND support for the TQM8548 modules Wolfgang Grandegger
@ 2009-02-13 20:58 ` Scott Wood
[not found] ` <bb70857e0902160123r5b4747b2naaf79ac418b1606e@mail.gmail.com>
5 siblings, 1 reply; 13+ messages in thread
From: Scott Wood @ 2009-02-13 20:58 UTC (permalink / raw)
To: u-boot
On Wed, Feb 11, 2009 at 06:38:19PM +0100, Wolfgang Grandegger wrote:
> The following patch series intends to support the Micron multi-chip
> NAND device MT29F8G08FAB on the TQM8548 modules from TQ-Components.
> To offer this multi-chip device as one single device to the user,
> multi-chip device has been added to the MTD NAND layer and the
> FSL-UPM-NAND driver.
>
> The TQM8548 support is based on the following patch series sent
> a few minutes ago:
>
> [PATCH 0/8] MPC85xx: Support for TQM8548-AG and TQM8548-BE
>
> Wolfgang.
Applied 1-5 to u-boot-nand-flash/next, thanks!
-Scott
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM
2009-02-11 17:38 ` [U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM Wolfgang Grandegger
@ 2009-02-13 20:59 ` Scott Wood
2009-02-13 21:22 ` Wolfgang Grandegger
0 siblings, 1 reply; 13+ messages in thread
From: Scott Wood @ 2009-02-13 20:59 UTC (permalink / raw)
To: u-boot
On Wed, Feb 11, 2009 at 06:38:22PM +0100, Wolfgang Grandegger wrote:
> Index: u-boot/drivers/mtd/nand/fsl_upm.c
> ===================================================================
> --- u-boot.orig/drivers/mtd/nand/fsl_upm.c
> +++ u-boot/drivers/mtd/nand/fsl_upm.c
> @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info
> mar = cmd << (32 - fun->width);
> io_addr = fun->upm.io_addr;
> #if CONFIG_SYS_NAND_MAX_CHIPS > 1
> - if (fun->chip_nr > 0)
> + if (fun->chip_nr > 0) {
> io_addr += fun->chip_offset * fun->chip_nr;
> + if (fun->upm_mar_chip_offset)
> + mar |= fun->upm_mar_chip_offset * fun->chip_nr;
> + }
Any particular reason not to drop the > 0 conditional?
-Scott
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM
2009-02-13 20:59 ` Scott Wood
@ 2009-02-13 21:22 ` Wolfgang Grandegger
2009-02-13 21:30 ` Scott Wood
2009-02-13 21:35 ` Scott Wood
0 siblings, 2 replies; 13+ messages in thread
From: Wolfgang Grandegger @ 2009-02-13 21:22 UTC (permalink / raw)
To: u-boot
Scott Wood wrote:
> On Wed, Feb 11, 2009 at 06:38:22PM +0100, Wolfgang Grandegger wrote:
>> Index: u-boot/drivers/mtd/nand/fsl_upm.c
>> ===================================================================
>> --- u-boot.orig/drivers/mtd/nand/fsl_upm.c
>> +++ u-boot/drivers/mtd/nand/fsl_upm.c
>> @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info
>> mar = cmd << (32 - fun->width);
>> io_addr = fun->upm.io_addr;
>> #if CONFIG_SYS_NAND_MAX_CHIPS > 1
>> - if (fun->chip_nr > 0)
>> + if (fun->chip_nr > 0) {
>> io_addr += fun->chip_offset * fun->chip_nr;
>> + if (fun->upm_mar_chip_offset)
>> + mar |= fun->upm_mar_chip_offset * fun->chip_nr;
>> + }
>
> Any particular reason not to drop the > 0 conditional?
No, apart from saving some space. Should I send an updated patch?
Wolfgang.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM
2009-02-13 21:22 ` Wolfgang Grandegger
@ 2009-02-13 21:30 ` Scott Wood
2009-02-13 21:35 ` Scott Wood
1 sibling, 0 replies; 13+ messages in thread
From: Scott Wood @ 2009-02-13 21:30 UTC (permalink / raw)
To: u-boot
Wolfgang Grandegger wrote:
> Scott Wood wrote:
>> On Wed, Feb 11, 2009 at 06:38:22PM +0100, Wolfgang Grandegger wrote:
>>> Index: u-boot/drivers/mtd/nand/fsl_upm.c
>>> ===================================================================
>>> --- u-boot.orig/drivers/mtd/nand/fsl_upm.c
>>> +++ u-boot/drivers/mtd/nand/fsl_upm.c
>>> @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info
>>> mar = cmd << (32 - fun->width);
>>> io_addr = fun->upm.io_addr;
>>> #if CONFIG_SYS_NAND_MAX_CHIPS > 1
>>> - if (fun->chip_nr > 0)
>>> + if (fun->chip_nr > 0) {
>>> io_addr += fun->chip_offset * fun->chip_nr;
>>> + if (fun->upm_mar_chip_offset)
>>> + mar |= fun->upm_mar_chip_offset * fun->chip_nr;
>>> + }
>> Any particular reason not to drop the > 0 conditional?
>
> No, apart from saving some space. Should I send an updated patch?
No, I've applied it. You can send a follow-up patch if you like.
-Scott
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM
2009-02-13 21:22 ` Wolfgang Grandegger
2009-02-13 21:30 ` Scott Wood
@ 2009-02-13 21:35 ` Scott Wood
1 sibling, 0 replies; 13+ messages in thread
From: Scott Wood @ 2009-02-13 21:35 UTC (permalink / raw)
To: u-boot
Wolfgang Grandegger wrote:
> Scott Wood wrote:
>> On Wed, Feb 11, 2009 at 06:38:22PM +0100, Wolfgang Grandegger wrote:
>>> Index: u-boot/drivers/mtd/nand/fsl_upm.c
>>> ===================================================================
>>> --- u-boot.orig/drivers/mtd/nand/fsl_upm.c
>>> +++ u-boot/drivers/mtd/nand/fsl_upm.c
>>> @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info
>>> mar = cmd << (32 - fun->width);
>>> io_addr = fun->upm.io_addr;
>>> #if CONFIG_SYS_NAND_MAX_CHIPS > 1
>>> - if (fun->chip_nr > 0)
>>> + if (fun->chip_nr > 0) {
>>> io_addr += fun->chip_offset * fun->chip_nr;
>>> + if (fun->upm_mar_chip_offset)
>>> + mar |= fun->upm_mar_chip_offset * fun->chip_nr;
>>> + }
>> Any particular reason not to drop the > 0 conditional?
>
> No, apart from saving some space. Should I send an updated patch?
BTW, it seems to me that the conditional adds to the image size, rather
than reducing it...
-Scott
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] Fwd: [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548
[not found] ` <bb70857e0902160123r5b4747b2naaf79ac418b1606e@mail.gmail.com>
@ 2009-02-16 9:28 ` arun sharma
2009-02-16 13:08 ` Wolfgang Grandegger
0 siblings, 1 reply; 13+ messages in thread
From: arun sharma @ 2009-02-16 9:28 UTC (permalink / raw)
To: u-boot
>* Index: u-boot/drivers/mtd/nand/fsl_upm.c
*>* ===================================================================
*>* --- u-boot.orig/drivers/mtd/nand/fsl_upm.c
*>* +++ u-boot/drivers/mtd/nand/fsl_upm.c
*>* @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info
*>* mar = cmd << (32 - fun->width);
*>* io_addr = fun->upm.io_addr;
*>* #if CONFIG_SYS_NAND_MAX_CHIPS > 1
*>* - if (fun->chip_nr > 0)
*>* + if (fun->chip_nr > 0) {
*>* io_addr += fun->chip_offset * fun->chip_nr;
*>* + if (fun->upm_mar_chip_offset)
*>* + mar |= fun->upm_mar_chip_offset * fun->chip_nr;
*>* + }
*
above patch is not suitable for 832x becuase mar register has only 26
bit (6 bit are resrved)
what should be done
On Sat, Feb 14, 2009 at 2:28 AM, Scott Wood <scottwood@freescale.com> wrote:
> On Wed, Feb 11, 2009 at 06:38:19PM +0100, Wolfgang Grandegger wrote:
> > The following patch series intends to support the Micron multi-chip
> > NAND device MT29F8G08FAB on the TQM8548 modules from TQ-Components.
> > To offer this multi-chip device as one single device to the user,
> > multi-chip device has been added to the MTD NAND layer and the
> > FSL-UPM-NAND driver.
> >
> > The TQM8548 support is based on the following patch series sent
> > a few minutes ago:
> >
> > [PATCH 0/8] MPC85xx: Support for TQM8548-AG and TQM8548-BE
> >
> > Wolfgang.
>
> Applied 1-5 to u-boot-nand-flash/next, thanks!
>
> -Scott
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] Fwd: [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548
2009-02-16 9:28 ` [U-Boot] Fwd: " arun sharma
@ 2009-02-16 13:08 ` Wolfgang Grandegger
0 siblings, 0 replies; 13+ messages in thread
From: Wolfgang Grandegger @ 2009-02-16 13:08 UTC (permalink / raw)
To: u-boot
arun sharma wrote:
>> * Index: u-boot/drivers/mtd/nand/fsl_upm.c
> *>* ===================================================================
> *>* --- u-boot.orig/drivers/mtd/nand/fsl_upm.c
> *>* +++ u-boot/drivers/mtd/nand/fsl_upm.c
> *>* @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info
> *>* mar = cmd << (32 - fun->width);
> *>* io_addr = fun->upm.io_addr;
> *>* #if CONFIG_SYS_NAND_MAX_CHIPS > 1
> *>* - if (fun->chip_nr > 0)
> *>* + if (fun->chip_nr > 0) {
> *>* io_addr += fun->chip_offset * fun->chip_nr;
> *>* + if (fun->upm_mar_chip_offset)
> *>* + mar |= fun->upm_mar_chip_offset * fun->chip_nr;
> *>* + }
> *
> above patch is not suitable for 832x becuase mar register has only 26
> bit (6 bit are resrved)
> what should be done
Simply do not define fun->upm_mar_chip_offset in your BSP code. It is
used on the TQM8548 modules to driver some board-specific chip select
logic. Anyhow, do you need to support a multi-chip (multi-die) device all?
Wolfgang.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2009-02-16 13:08 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-11 17:38 [U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548 Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 1/5] Enable multi chip support in the NAND layer Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 2/5] Add multi chip support to the FSL-UPM driver Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 3/5] Add support for TQM-specific chip select logic to FSL-UPM Wolfgang Grandegger
2009-02-13 20:59 ` Scott Wood
2009-02-13 21:22 ` Wolfgang Grandegger
2009-02-13 21:30 ` Scott Wood
2009-02-13 21:35 ` Scott Wood
2009-02-11 17:38 ` [U-Boot] [PATCH v2 4/5] Add wait flags to support board/chip specific delays Wolfgang Grandegger
2009-02-11 17:38 ` [U-Boot] [PATCH v2 5/5] Add multi-chip NAND support for the TQM8548 modules Wolfgang Grandegger
2009-02-13 20:58 ` [U-Boot] [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548 Scott Wood
[not found] ` <bb70857e0902160123r5b4747b2naaf79ac418b1606e@mail.gmail.com>
2009-02-16 9:28 ` [U-Boot] Fwd: " arun sharma
2009-02-16 13:08 ` Wolfgang Grandegger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox