From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Date: Mon, 16 Feb 2009 14:08:20 +0100 Subject: [U-Boot] Fwd: [PATCH v2 0/5] Add multi-chips support for NAND, FSL-UPM and TQM8548 In-Reply-To: References: <20090211173819.399651539@grandegger.com> <20090213205853.GA25384@ld0162-tx32.am.freescale.net> Message-ID: <49996544.7050009@grandegger.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de arun sharma wrote: >> * Index: u-boot/drivers/mtd/nand/fsl_upm.c > *>* =================================================================== > *>* --- u-boot.orig/drivers/mtd/nand/fsl_upm.c > *>* +++ u-boot/drivers/mtd/nand/fsl_upm.c > *>* @@ -90,8 +90,11 @@ static void fun_cmd_ctrl(struct mtd_info > *>* mar = cmd << (32 - fun->width); > *>* io_addr = fun->upm.io_addr; > *>* #if CONFIG_SYS_NAND_MAX_CHIPS > 1 > *>* - if (fun->chip_nr > 0) > *>* + if (fun->chip_nr > 0) { > *>* io_addr += fun->chip_offset * fun->chip_nr; > *>* + if (fun->upm_mar_chip_offset) > *>* + mar |= fun->upm_mar_chip_offset * fun->chip_nr; > *>* + } > * > above patch is not suitable for 832x becuase mar register has only 26 > bit (6 bit are resrved) > what should be done Simply do not define fun->upm_mar_chip_offset in your BSP code. It is used on the TQM8548 modules to driver some board-specific chip select logic. Anyhow, do you need to support a multi-chip (multi-die) device all? Wolfgang.