From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 16 Feb 2009 13:00:59 -0600 Subject: [U-Boot] [PATCH 27/27] remove bi_enet*addr from global data for all arches In-Reply-To: <200902161357.54008.vapier@gentoo.org> References: <1234596190-524-1-git-send-email-vapier@gentoo.org> <1234596190-524-28-git-send-email-vapier@gentoo.org> <20090216181638.GA18182@ld0162-tx32.am.freescale.net> <200902161357.54008.vapier@gentoo.org> Message-ID: <4999B7EB.2060602@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Mike Frysinger wrote: > On Monday 16 February 2009 13:16:38 Scott Wood wrote: >> This will break compatibility with pre-device-tree kernels. >> >> bd_t is a public interface, albeit a deprecated one. > > the fact that the size can change based on board configs makes it already a > pretty unreliable ABI ... Sure, that's why it's deprecated. :-) > at any rate, is there a define that can be keyed off of ? CONFIG_HAS_FDT or > some such junk ? then the behavior can be changed to like: > #ifndef CONFIG_HAS_FDT > /* ABI compat junk */ > uchar bi_padding_was_enetaddr[6]; > #endif Why not just leave the bd_t alone, until such a time as we can get rid of it altogether? Note that just because we support booting with device trees doesn't mean we don't also support booting legacy kernels. -Scott