public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] bootm: Reduce the unnecessary memmove
Date: Tue, 17 Feb 2009 16:29:48 +0900	[thread overview]
Message-ID: <499A676C.90207@samsung.com> (raw)

Although load address and image start address are same address, bootm command does memmove.
That is unnecessary memmove and can be taken few milliseconds (about 500 msec to 1000 msec).
If reduce this memmove, we can reduce the boot time.

Please check this patch.

Thank you.
Minkyu Kang.


Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
---
diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
index 07f6c6b..437f3f8 100644
--- a/common/cmd_bootm.c
+++ b/common/cmd_bootm.c
@@ -340,7 +340,8 @@ static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress)
 		} else {
 			printf ("   Loading %s ... ", type_name);
 
-			memmove_wd ((void *)load,
+			if (load != image_start)
+				memmove_wd ((void *)load,
 				   (void *)image_start, image_len, CHUNKSZ);
 		}
 		*load_end = load + image_len;

             reply	other threads:[~2009-02-17  7:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-17  7:29 Minkyu Kang [this message]
2009-02-17  8:19 ` [U-Boot] [PATCH] bootm: Reduce the unnecessary memmove Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2009-02-18  0:05 Minkyu Kang
2009-02-21 22:00 ` Wolfgang Denk
2009-02-22 16:05 ` Larry Johnson
2009-02-22 21:34   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499A676C.90207@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox