* [U-Boot] [PATCH] bootm: Reduce the unnecessary memmove
@ 2009-02-17 7:29 Minkyu Kang
2009-02-17 8:19 ` Wolfgang Denk
0 siblings, 1 reply; 6+ messages in thread
From: Minkyu Kang @ 2009-02-17 7:29 UTC (permalink / raw)
To: u-boot
Although load address and image start address are same address, bootm command does memmove.
That is unnecessary memmove and can be taken few milliseconds (about 500 msec to 1000 msec).
If reduce this memmove, we can reduce the boot time.
Please check this patch.
Thank you.
Minkyu Kang.
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
---
diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
index 07f6c6b..437f3f8 100644
--- a/common/cmd_bootm.c
+++ b/common/cmd_bootm.c
@@ -340,7 +340,8 @@ static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress)
} else {
printf (" Loading %s ... ", type_name);
- memmove_wd ((void *)load,
+ if (load != image_start)
+ memmove_wd ((void *)load,
(void *)image_start, image_len, CHUNKSZ);
}
*load_end = load + image_len;
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] bootm: Reduce the unnecessary memmove
2009-02-17 7:29 [U-Boot] [PATCH] bootm: Reduce the unnecessary memmove Minkyu Kang
@ 2009-02-17 8:19 ` Wolfgang Denk
0 siblings, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2009-02-17 8:19 UTC (permalink / raw)
To: u-boot
Dear Minkyu Kang,
In message <499A676C.90207@samsung.com> you wrote:
> Although load address and image start address are same address, bootm command does memmove.
> That is unnecessary memmove and can be taken few milliseconds (about 500 msec to 1000 msec).
> If reduce this memmove, we can reduce the boot time.
Please use shorer lines - 70 characters max.
> Please check this patch.
>
> Thank you.
> Minkyu Kang.
Please move the comments and greetings...
>
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> ---
...below this "---" line as they would become part of the commit
message otherwise.
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> index 07f6c6b..437f3f8 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -340,7 +340,8 @@ static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress)
> } else {
> printf (" Loading %s ... ", type_name);
>
> - memmove_wd ((void *)load,
> + if (load != image_start)
> + memmove_wd ((void *)load,
> (void *)image_start, image_len, CHUNKSZ);
Please use curly braces around the two-line statement; and increase
the indent for the last line.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
...when fits of creativity run strong, more than one programmer or
writer has been known to abandon the desktop for the more spacious
floor. - Fred Brooks, Jr.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] bootm: Reduce the unnecessary memmove
@ 2009-02-18 0:05 Minkyu Kang
2009-02-21 22:00 ` Wolfgang Denk
2009-02-22 16:05 ` Larry Johnson
0 siblings, 2 replies; 6+ messages in thread
From: Minkyu Kang @ 2009-02-18 0:05 UTC (permalink / raw)
To: u-boot
Although load address and image start address are same address,
bootm command always does memmove.
That is unnecessary memmove and can be taken few milliseconds
(about 500 msec to 1000 msec).
If skip this memmove, we can reduce the boot time.
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
---
common/cmd_bootm.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
index 07f6c6b..6fdeef4 100644
--- a/common/cmd_bootm.c
+++ b/common/cmd_bootm.c
@@ -340,8 +340,10 @@ static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress)
} else {
printf (" Loading %s ... ", type_name);
- memmove_wd ((void *)load,
- (void *)image_start, image_len, CHUNKSZ);
+ if (load != image_start) {
+ memmove_wd ((void *)load,
+ (void *)image_start, image_len, CHUNKSZ);
+ }
}
*load_end = load + image_len;
puts("OK\n");
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] bootm: Reduce the unnecessary memmove
2009-02-18 0:05 Minkyu Kang
@ 2009-02-21 22:00 ` Wolfgang Denk
2009-02-22 16:05 ` Larry Johnson
1 sibling, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2009-02-21 22:00 UTC (permalink / raw)
To: u-boot
Dear Minkyu Kang,
In message <499B50E0.8040501@samsung.com> you wrote:
> Although load address and image start address are same address,
> bootm command always does memmove.
> That is unnecessary memmove and can be taken few milliseconds
> (about 500 msec to 1000 msec).
> If skip this memmove, we can reduce the boot time.
>
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> ---
> common/cmd_bootm.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If some day we are defeated, well, war has its fortunes, good and
bad.
-- Commander Kor, "Errand of Mercy", stardate 3201.7
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] bootm: Reduce the unnecessary memmove
2009-02-18 0:05 Minkyu Kang
2009-02-21 22:00 ` Wolfgang Denk
@ 2009-02-22 16:05 ` Larry Johnson
2009-02-22 21:34 ` Wolfgang Denk
1 sibling, 1 reply; 6+ messages in thread
From: Larry Johnson @ 2009-02-22 16:05 UTC (permalink / raw)
To: u-boot
Minkyu Kang wrote:
> Although load address and image start address are same address,
> bootm command always does memmove.
> That is unnecessary memmove and can be taken few milliseconds
> (about 500 msec to 1000 msec).
> If skip this memmove, we can reduce the boot time.
>
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> ---
> common/cmd_bootm.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> index 07f6c6b..6fdeef4 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -340,8 +340,10 @@ static int bootm_load_os(image_info_t os, ulong *load_end, int boot_progress)
> } else {
> printf (" Loading %s ... ", type_name);
>
> - memmove_wd ((void *)load,
> - (void *)image_start, image_len, CHUNKSZ);
> + if (load != image_start) {
> + memmove_wd ((void *)load,
> + (void *)image_start, image_len, CHUNKSZ);
> + }
> }
> *load_end = load + image_len;
> puts("OK\n");
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Sorry for the late reply, but would it be better to put the test of
source == destination into the memmove_wd() function?
Best regards,
Larry
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] bootm: Reduce the unnecessary memmove
2009-02-22 16:05 ` Larry Johnson
@ 2009-02-22 21:34 ` Wolfgang Denk
0 siblings, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2009-02-22 21:34 UTC (permalink / raw)
To: u-boot
Dear Larry Johnson,
In message <49A177D8.1050702@acm.org> you wrote:
>
> > Although load address and image start address are same address,
> > bootm command always does memmove.
> > That is unnecessary memmove and can be taken few milliseconds
> > (about 500 msec to 1000 msec).
> > If skip this memmove, we can reduce the boot time.
...
> Sorry for the late reply, but would it be better to put the test of
> source == destination into the memmove_wd() function?
Yes, indeed.
Can you please send a patch?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
This was an amazing creation using small squares of compressed
vegetable matter on which letters were made by means of small carbon
particles from a stylus, giving an effect similar to the traditional
word-processor screen. It seemed amazingly portable and I never once
saw him have to change the batteries.
- Terry Pratchett & Stephen Briggs, _The Discworld Companion_
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-02-22 21:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-17 7:29 [U-Boot] [PATCH] bootm: Reduce the unnecessary memmove Minkyu Kang
2009-02-17 8:19 ` Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2009-02-18 0:05 Minkyu Kang
2009-02-21 22:00 ` Wolfgang Denk
2009-02-22 16:05 ` Larry Johnson
2009-02-22 21:34 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox