public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Felix Radensky <felix@embedded-sol.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: PCIe: Change 16GB inbound memory to 4GB
Date: Wed, 18 Feb 2009 14:43:07 +0200	[thread overview]
Message-ID: <499C025B.9050509@embedded-sol.com> (raw)
In-Reply-To: <1234959871-2103-1-git-send-email-sr@denx.de>

Stefan Roese wrote:
> This patch fixes a problem recently seen on some 4xx platforms. For
> example on Kilauea PCIe slot #0.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>
> Felix, could you please test on your Kilaue with this patch applied?
> It fixes the problem on my system but please report if your board
> now boots correctly with the PCIe card plugged into both slots.
>
> Thanks.
>   

Yes, this fixes my problem. Tested with single slot populated (0 and 1)
and with 2 slots populated.

Thanks a lot for a quick fix.

Felix.
>  cpu/ppc4xx/4xx_pcie.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cpu/ppc4xx/4xx_pcie.c b/cpu/ppc4xx/4xx_pcie.c
> index 58d96bb..07fbb0e 100644
> --- a/cpu/ppc4xx/4xx_pcie.c
> +++ b/cpu/ppc4xx/4xx_pcie.c
> @@ -1028,10 +1028,10 @@ void ppc4xx_setup_pcie_rootpoint(struct pci_controller *hose, int port)
>  #endif
>  	}
>  
> -	/* Set up 16GB inbound memory window at 0 */
> +	/* Set up 4GB inbound memory window at 0 */
>  	out_le32(mbase + PCI_BASE_ADDRESS_0, 0);
>  	out_le32(mbase + PCI_BASE_ADDRESS_1, 0);
> -	out_le32(mbase + PECFG_BAR0HMPA, 0x7fffffc);
> +	out_le32(mbase + PECFG_BAR0HMPA, 0x7ffffff);
>  	out_le32(mbase + PECFG_BAR0LMPA, 0);
>  
>  	out_le32(mbase + PECFG_PIM01SAH, 0xffff0000);
>   

      reply	other threads:[~2009-02-18 12:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-18 12:24 [U-Boot] [PATCH] ppc4xx: PCIe: Change 16GB inbound memory to 4GB Stefan Roese
2009-02-18 12:43 ` Felix Radensky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499C025B.9050509@embedded-sol.com \
    --to=felix@embedded-sol.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox