public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] ppc4xx: PCIe: Change 16GB inbound memory to 4GB
@ 2009-02-18 12:24 Stefan Roese
  2009-02-18 12:43 ` Felix Radensky
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Roese @ 2009-02-18 12:24 UTC (permalink / raw)
  To: u-boot

This patch fixes a problem recently seen on some 4xx platforms. For
example on Kilauea PCIe slot #0.

Signed-off-by: Stefan Roese <sr@denx.de>
---

Felix, could you please test on your Kilaue with this patch applied?
It fixes the problem on my system but please report if your board
now boots correctly with the PCIe card plugged into both slots.

Thanks.

 cpu/ppc4xx/4xx_pcie.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpu/ppc4xx/4xx_pcie.c b/cpu/ppc4xx/4xx_pcie.c
index 58d96bb..07fbb0e 100644
--- a/cpu/ppc4xx/4xx_pcie.c
+++ b/cpu/ppc4xx/4xx_pcie.c
@@ -1028,10 +1028,10 @@ void ppc4xx_setup_pcie_rootpoint(struct pci_controller *hose, int port)
 #endif
 	}
 
-	/* Set up 16GB inbound memory window at 0 */
+	/* Set up 4GB inbound memory window at 0 */
 	out_le32(mbase + PCI_BASE_ADDRESS_0, 0);
 	out_le32(mbase + PCI_BASE_ADDRESS_1, 0);
-	out_le32(mbase + PECFG_BAR0HMPA, 0x7fffffc);
+	out_le32(mbase + PECFG_BAR0HMPA, 0x7ffffff);
 	out_le32(mbase + PECFG_BAR0LMPA, 0);
 
 	out_le32(mbase + PECFG_PIM01SAH, 0xffff0000);
-- 
1.6.1.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] ppc4xx: PCIe: Change 16GB inbound memory to 4GB
  2009-02-18 12:24 [U-Boot] [PATCH] ppc4xx: PCIe: Change 16GB inbound memory to 4GB Stefan Roese
@ 2009-02-18 12:43 ` Felix Radensky
  0 siblings, 0 replies; 2+ messages in thread
From: Felix Radensky @ 2009-02-18 12:43 UTC (permalink / raw)
  To: u-boot

Stefan Roese wrote:
> This patch fixes a problem recently seen on some 4xx platforms. For
> example on Kilauea PCIe slot #0.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>
> Felix, could you please test on your Kilaue with this patch applied?
> It fixes the problem on my system but please report if your board
> now boots correctly with the PCIe card plugged into both slots.
>
> Thanks.
>   

Yes, this fixes my problem. Tested with single slot populated (0 and 1)
and with 2 slots populated.

Thanks a lot for a quick fix.

Felix.
>  cpu/ppc4xx/4xx_pcie.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cpu/ppc4xx/4xx_pcie.c b/cpu/ppc4xx/4xx_pcie.c
> index 58d96bb..07fbb0e 100644
> --- a/cpu/ppc4xx/4xx_pcie.c
> +++ b/cpu/ppc4xx/4xx_pcie.c
> @@ -1028,10 +1028,10 @@ void ppc4xx_setup_pcie_rootpoint(struct pci_controller *hose, int port)
>  #endif
>  	}
>  
> -	/* Set up 16GB inbound memory window at 0 */
> +	/* Set up 4GB inbound memory window at 0 */
>  	out_le32(mbase + PCI_BASE_ADDRESS_0, 0);
>  	out_le32(mbase + PCI_BASE_ADDRESS_1, 0);
> -	out_le32(mbase + PECFG_BAR0HMPA, 0x7fffffc);
> +	out_le32(mbase + PECFG_BAR0HMPA, 0x7ffffff);
>  	out_le32(mbase + PECFG_BAR0LMPA, 0);
>  
>  	out_le32(mbase + PECFG_PIM01SAH, 0xffff0000);
>   

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-02-18 12:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-18 12:24 [U-Boot] [PATCH] ppc4xx: PCIe: Change 16GB inbound memory to 4GB Stefan Roese
2009-02-18 12:43 ` Felix Radensky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox