public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Create configuration option for restricted ns16550 functions
Date: Wed, 18 Feb 2009 12:12:13 -0600	[thread overview]
Message-ID: <499C4F7D.6020006@freescale.com> (raw)
In-Reply-To: <20090218122152.7fbe1e25.kim.phillips@freescale.com>

Kim Phillips wrote:
> So this patch gives this when CONFIG_NS16550_MIN_FUNCTIONS is set:
> 
> /home/r1aaha/git/u-boot/drivers/serial/serial.c:229: undefined reference to `NS16550_reinit'
> drivers/serial/libserial.a(serial.o): In function `_serial_tstc':
> /home/r1aaha/git/u-boot/drivers/serial/serial.c:220: undefined reference to `NS16550_tstc'
> drivers/serial/libserial.a(serial.o): In function `_serial_getc':
> /home/r1aaha/git/u-boot/drivers/serial/serial.c:214: undefined reference to `NS16550_getc'
> make: *** [u-boot] Error 1

So don't define that symbol if you're going to be using the functions 
that we're trying to trim away.

> this is my proposed fix:
> 
> diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
> index 1b347e9..9c0055f 100644
> --- a/drivers/serial/ns16550.c
> +++ b/drivers/serial/ns16550.c
> @@ -54,6 +54,8 @@ void NS16550_reinit (NS16550_t com_port, int baud_divisor)
>         com_port->dlm = (baud_divisor >> 8) & 0xff;
>         com_port->lcr = LCRVAL;
>  }
> +#else
> +void NS16550_reinit (NS16550_t com_port, int baud_divisor) { }

No, this adds bytes.  The whole purpose of this is to cut away bytes for 
NAND bootstraps.

-Scott

  reply	other threads:[~2009-02-18 18:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-17 20:14 [U-Boot] [PATCH v2] Create configuration option for restricted ns16550 functions Ron Madrid
2009-02-18 18:21 ` Kim Phillips
2009-02-18 18:12   ` Scott Wood [this message]
2009-02-18 18:29   ` Wolfgang Denk
2009-02-18 20:01     ` Kim Phillips
2009-02-18 19:54       ` Scott Wood
2009-02-18 20:02       ` Ron Madrid
2009-02-18 20:45         ` Kim Phillips
2009-02-18 22:11         ` Wolfgang Denk
2009-02-18 23:23           ` Kim Phillips
2009-02-18 23:36             ` Wolfgang Denk
2009-02-18 18:30   ` Kim Phillips
2009-02-18 19:02     ` Ron Madrid
2009-02-18 21:58       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=499C4F7D.6020006@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox