From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Wed, 18 Feb 2009 12:12:13 -0600
Subject: [U-Boot] [PATCH v2] Create configuration option for restricted
 ns16550 functions
In-Reply-To: <20090218122152.7fbe1e25.kim.phillips@freescale.com>
References: <1234901657-5699-1-git-send-email-ron_madrid@sbcglobal.net>
	<20090218122152.7fbe1e25.kim.phillips@freescale.com>
Message-ID: <499C4F7D.6020006@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Kim Phillips wrote:
> So this patch gives this when CONFIG_NS16550_MIN_FUNCTIONS is set:
> 
> /home/r1aaha/git/u-boot/drivers/serial/serial.c:229: undefined reference to `NS16550_reinit'
> drivers/serial/libserial.a(serial.o): In function `_serial_tstc':
> /home/r1aaha/git/u-boot/drivers/serial/serial.c:220: undefined reference to `NS16550_tstc'
> drivers/serial/libserial.a(serial.o): In function `_serial_getc':
> /home/r1aaha/git/u-boot/drivers/serial/serial.c:214: undefined reference to `NS16550_getc'
> make: *** [u-boot] Error 1

So don't define that symbol if you're going to be using the functions 
that we're trying to trim away.

> this is my proposed fix:
> 
> diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
> index 1b347e9..9c0055f 100644
> --- a/drivers/serial/ns16550.c
> +++ b/drivers/serial/ns16550.c
> @@ -54,6 +54,8 @@ void NS16550_reinit (NS16550_t com_port, int baud_divisor)
>         com_port->dlm = (baud_divisor >> 8) & 0xff;
>         com_port->lcr = LCRVAL;
>  }
> +#else
> +void NS16550_reinit (NS16550_t com_port, int baud_divisor) { }

No, this adds bytes.  The whole purpose of this is to cut away bytes for 
NAND bootstraps.

-Scott