From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Date: Thu, 19 Feb 2009 20:22:47 -0600 Subject: [U-Boot] [PATCH] ARM:OMAP3 Change mmc_init to mmc_legacy_init In-Reply-To: <20090219230739.879A3832E43F@gemini.denx.de> References: <1235083543-4659-1-git-send-email-Tom.Rix@windriver.com> <20090219225148.01866832E43F@gemini.denx.de> <20090219230739.879A3832E43F@gemini.denx.de> Message-ID: <499E13F7.6020909@windriver.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Dear Tom, > > in message <20090219225148.01866832E43F@gemini.denx.de> I wrote: > >>> omap3_mmc.c was changed to define mmc_legacy_init. >>> Remove unused functions. >>> >>> Compile tested on all arm >>> Runtime tested on Zoom1. >>> >>> Signed-off-by: Tom Rix >>> --- >>> drivers/mmc/omap3_mmc.c | 17 ++--------------- >>> 1 files changed, 2 insertions(+), 15 deletions(-) >>> >> Applied, thanks. >> > > ...but there are still build errors on ARM: > > Configuring for cerf250 board... > In file included from mmc.c:31: > mmc.h:139: error: redefinition of 'struct mmc_cid' > mmc.h:151: error: redefinition of 'struct mmc_csd' > The recent patches I posted should fix this problems. They appear to be only in pxa. The changes looked obvious. MAKEBUILDALL arm and grep-ing for mmc in the *.ERR file were used to test the compile. I do not have a pxa target so I was unable to do a runtime test. It would be a good idea for someone with a pxa board like cerf250 to test these changes. Tom